Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m_renderTarget caching causes crash in GTA: VC trace #64

Closed
AlpyneDreams opened this issue Nov 19, 2022 · 2 comments
Closed

m_renderTarget caching causes crash in GTA: VC trace #64

AlpyneDreams opened this issue Nov 19, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@AlpyneDreams
Copy link
Owner

In the GTA Vice City trace file, and probably other places, caching the active rendertarget (b46bb74) causes an access violation.

It has been reverted for now (0c563be) while this issue is open.
@AlpyneDreams AlpyneDreams added the bug Something isn't working label Nov 19, 2022
@WinterSnowfall
Copy link

Oh, so you had an issue open for it, missed that :)... in that case I'll add more detail here as well.

Other games that have issues with it: Curse - The Eye of Isis

Games that seem to need the ref: #98 #102

@AlpyneDreams
Copy link
Owner Author

Good news! This was fixed yesterday by 567b033!

It's also worth noting that sometimes this would crash in CreateTexture instead of SetRenderTarget, and I don't know why it was doing that. However this doesn't happen after 567b033 so I will not worry about that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlpyneDreams @WinterSnowfall