Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 'temporary value dropped while borrowed' error #2

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

ahenshaw
Copy link

Just removed an un-needed borrow that was causing a compilation error for me.

@Aloso
Copy link
Owner

Aloso commented Oct 28, 2020

Hi @ahenshaw, thanks for contributing! I'm glad that you're interested in this program.

Note that this is fixed in the new feature branch I was just about to merge. There will be a new release soon.

What OS do you use? Since I use Linux and don't have access to a macOS or Windows machine, it would be nice to have Windows or macOS testers who can report OS-specific issues., Let me know if you are open to it.

I'll merge this and rebase my feature branch then 😉

@Aloso Aloso merged commit 172e272 into Aloso:main Oct 28, 2020
@ahenshaw
Copy link
Author

ahenshaw commented Oct 29, 2020 via email

@Aloso
Copy link
Owner

Aloso commented Oct 31, 2020

@ahenshaw I wrote a GitHub workflow to automate releases, so the new version includes a Windows binary. Could you check that it works? That would be really appreciated!

@ahenshaw
Copy link
Author

ahenshaw commented Nov 6, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants