Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Replace Optional fields with Lists that accept a Union of options, ensure options have a valid name #1172

Open
5 tasks
dbirman opened this issue Dec 5, 2024 · 0 comments
Labels
breaking Breaking changes

Comments

@dbirman
Copy link
Member

dbirman commented Dec 5, 2024

Describe the solution you'd like

  • Core models with large numbers of Optional fields are replaced with List[Union[...]]
  • AindModel gets a new name field
  • AindModel children with an existing name field get removed
  • Validators check that all data in these lists have a valid name (non-empty string)
  • Write upgraders for all models that can take v1.X files and upgrade to 2.0

Describe alternatives you've considered
The name field disambiguates options without the need for a dictionary.

Additional context
https://alleninstitute.sharepoint.com/:w:/r/sites/NeuralDynamics/_layouts/15/Doc.aspx?sourcedoc=%7BE27B889D-27A1-4CC0-948C-10ADBE605654%7D&file=Data+Schema+2.0.docx&action=default&mobileredirect=true&DefaultItemOpen=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes
Projects
None yet
Development

No branches or pull requests

1 participant