Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage ipfx issues #517

Closed
1 task done
wbwakeman opened this issue May 5, 2021 · 1 comment
Closed
1 task done

Triage ipfx issues #517

wbwakeman opened this issue May 5, 2021 · 1 comment
Assignees

Comments

@wbwakeman
Copy link

wbwakeman commented May 5, 2021

We need to get a handle of recent ipfx issues that are preventing data from being processed through the internal pipeline. Rusty has entered some issues recently, including some PRs, that need to be reviewed so that we can scope out well-defined pieces of work for this team. This issue is to review those issues, ask for additional information as needed, and gain the background needed so that these issues can be discussed and scoped with the Marmot team.

Timeboxed to 2 days.

#509 Rusty's file updates #509 (comment)
#515 IndexError: Cannot find ('EXTPCllATT',)
#516 Failed and dropped sweeps are being used in Feature Extraction

#508/PR511 Sweeps with tags must be included in sweep_states
#513/PR514 extract electrode_0 should check pipette resistance before
#507 Sweeps that fail qc are incorrectly recorded in LIMS with the state "auto passed"
#499 add ability to set specific sweep checks as optional

Validation criteria:

  • Issues are written so that Marmot team believes them to be well-defined with actionable pieces of work
@wbwakeman wbwakeman added this to the Marmot 2021-05-18 milestone May 5, 2021
@sgratiy sgratiy self-assigned this May 6, 2021
@sgratiy
Copy link
Contributor

sgratiy commented May 7, 2021

#509 Added comment with the tasks, closed Rusty's PR without merging. Priority: High, Estimate: 5
#515 Should be fixed automatically with #509. Priority: already Done
#516 Left comment with proposed solution. Must fix ephys_qc_v3_strategy.rb. Priority High, Estimate: 3 (assuming have local LIMS installed and that fix will amount to reverting a few lines of code).

#508/PR511 Reviewed PR. Fix works with minor suggestion. General solution needed for future (create an issue). Responded to Tom with discussion on more general epoch inference. He may submit an PR. Priority: High, Estimate:3
#513/PR513 Review PR, asked Rusty for clarification. Priority: low, Estimate:TBD
#507 part 1 of the issue should be fixed with #516, proposed the fix for part 2. Priority:High, Estimate:1
#499 Added proposed solution in the comment. Priority: Low, Estimate:5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants