Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce network calls for zarr rendering #162

Closed
BrianWhitneyAI opened this issue Jul 5, 2024 · 2 comments
Closed

Reduce network calls for zarr rendering #162

BrianWhitneyAI opened this issue Jul 5, 2024 · 2 comments

Comments

@BrianWhitneyAI
Copy link
Contributor

          Works for me locally! Below are thoughts that don't need to be addressed rn: 

My only concern is that this requires a lot of network calls at once, including multiple expected non-breaking 404s per file. The main build up is on initial load, which makes sense, but also happens if you just click away from a file that's already loaded once and click back into it, so they can multiply quickly and cause some slowness. I'm wondering if there is some way we can cache...something?, but not sure if that's a realistic possibility.

Here's the network log after clicking into one file after clearing logs from initial page load:
Screenshot 2024-07-03 at 5 07 51 PM

Originally posted by @aswallace in #143 (review)

@BrianWhitneyAI
Copy link
Contributor Author

A portion of this is because the zarrita package makes calls for files that do not exist, searching for additional context. "zarr.json" for example.

@SeanLeRoy
Copy link
Contributor

This seems like a performance issue with zarrita not us, closing for now since it seems like a non-issue for now

@SeanLeRoy SeanLeRoy closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants