-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make main entry point be index.js instead of dist build #440
Comments
@ianks, sorry I can't got you. I've use |
currently the minified version is used as the main entry in package.json. I am suggesting we don't do that. |
@ianks, ok I understand. I'll do some survey. if have any solution, PR is welcome |
Hey @AllenFang I've been out, a lot of work. On the PR that I did - improve build - I set the entry point to lib/index.js but I saw that someone changed it after that back to dist. If you see my comment on the gulpfile you can understand why I did it and why @ianks is telling you that. Cheers |
@staminaloops, thanks, I'll figure out why the entry point been changed. 👍 |
hi all, I found this problem is since |
Released on |
Currently, we are using the dist build for this main entry point. This is problematical since bundlers like webpack cannot do things like sourcemaps easily. Also, the code is much harder to grok.
Do you think it would be reasonable to make the compiled index.js the main entry point instead?
ref: https://github.com/AllenFang/react-bootstrap-table/blob/master/package.json#L5
The text was updated successfully, but these errors were encountered: