Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make main entry point be index.js instead of dist build #440

Closed
ianks opened this issue May 6, 2016 · 7 comments
Closed

Make main entry point be index.js instead of dist build #440

ianks opened this issue May 6, 2016 · 7 comments

Comments

@ianks
Copy link
Contributor

ianks commented May 6, 2016

Currently, we are using the dist build for this main entry point. This is problematical since bundlers like webpack cannot do things like sourcemaps easily. Also, the code is much harder to grok.

Do you think it would be reasonable to make the compiled index.js the main entry point instead?

ref: https://github.com/AllenFang/react-bootstrap-table/blob/master/package.json#L5

@AllenFang
Copy link
Owner

@ianks, sorry I can't got you. I've use ./src/index.js as the main entry point in webpack building.
https://github.com/AllenFang/react-bootstrap-table/blob/master/webpack.umd.config.js#L21

@ianks
Copy link
Contributor Author

ianks commented May 7, 2016

currently the minified version is used as the main entry in package.json. I am suggesting we don't do that.

@AllenFang
Copy link
Owner

@ianks, ok I understand. I'll do some survey. if have any solution, PR is welcome

@staminaloops
Copy link
Contributor

Hey @AllenFang I've been out, a lot of work. On the PR that I did - improve build - I set the entry point to lib/index.js but I saw that someone changed it after that back to dist. If you see my comment on the gulpfile you can understand why I did it and why @ianks is telling you that. Cheers

@AllenFang
Copy link
Owner

@staminaloops, thanks, I'll figure out why the entry point been changed. 👍

@AllenFang
Copy link
Owner

hi all, I found this problem is since v2.1.2 released, there's a PR change it, but I doesn't review it carefully. Sorry about that. I'll fix it on next version.
Thanks :)

@AllenFang
Copy link
Owner

Released on v2.3.1. Thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants