Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Added plugin support for multi-channel segmentations #388

Merged
merged 2 commits into from
Jun 27, 2024
Merged

🚀 Added plugin support for multi-channel segmentations #388

merged 2 commits into from
Jun 27, 2024

Conversation

amilworks
Copy link
Contributor

@amilworks amilworks commented Jun 14, 2024 •
edited
Loading

What does this PR do?

Fixes #387
Resolves AllenCell/allencell-segmenter-ml#374

This PR provides multi-channel segmentation support for the Cyto-DL segmentation plugin config. Before, we had hardcoded values 0 for the segmentation channel. These now are comprised of two configurable variables for the channels.

Breaking Changes

None that I foresee since this only affects the plugin config.

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

SO MUCH fun coding 🙃

@benjijamorris benjijamorris self-requested a review June 25, 2024 18:13
benjijamorris
benjijamorris requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@benjijamorris benjijamorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I think the only other change is to run pre-commit run -a

configs/data/im2im/segmentation_plugin.yaml Show resolved Hide resolved
@amilworks amilworks self-assigned this Jun 25, 2024
benjijamorris
benjijamorris approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@benjijamorris benjijamorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic!

@amilworks amilworks merged commit 6195a66 into main Jun 27, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjijamorris benjijamorris benjijamorris approved these changes

@yrkim98 yrkim98 yrkim98 approved these changes

Assignees

@amilworks amilworks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-channel segmentations Multi-Channel Segmentations
3 participants
@amilworks @yrkim98 @benjijamorris