341 create a way #384
Merged
341 create a way #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g error. Setup tests for changing exp home dir
saeliddp
reviewed
Jun 10, 2024
saeliddp
reviewed
Jun 10, 2024
saeliddp
reviewed
Jun 10, 2024
saeliddp
reviewed
Jun 10, 2024
saeliddp
approved these changes
Jun 10, 2024
yrkim98
approved these changes
Jun 11, 2024
…ies with checkpoint subdirectories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow users to find out where their
experiments_homedirectory is, and to change it.Changes
UserSettings.display_change_user_experiments_home- open a dialog displaying the current value, and allow the user to select a new one.UserSettings.prompt_for_user_experiments_homeis void, takes care of persisting the choice internally.Testing
Manual. Lmk if you think this calls for unit testing, currently I am feeling ok without it.
TODO
/Users/chrishu/.pyenv/versions/3.10.4/lib/python3.10/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 1 leaked semaphore objects to clean up at shutdown warnings.warn('resource_tracker: There appear to be %d '