Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Prevent VSCode from opening when remounting #5544

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

amanape
Copy link
Member

@amanape amanape commented Dec 12, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • VSCode URL would forcefully open in certain cases such as when the query handler is remounted (due to the use effect logic)

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below


Give a summary of what the PR does, explaining any non-trivial design decisions

  • Fetches the URL when necessary, but only open the URL when the user explicitly clicks the handler

Link of any specific issues this addresses
Resolves #5519


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:d848ea0-nikolaik   --name openhands-app-d848ea0   docker.all-hands.dev/all-hands-ai/openhands:d848ea0

@amanape amanape self-assigned this Dec 12, 2024
Copy link
Collaborator

@xingyaoww xingyaoww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@amanape amanape merged commit de75bd0 into main Dec 13, 2024
15 checks passed
@amanape amanape deleted the fix/vscode-open-on-mount branch December 13, 2024 05:35
@diwu-sf
Copy link
Contributor

diwu-sf commented Dec 13, 2024

Thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Regression, clicking into Jupyter tab, then clicking back into Workspace tab opens up VSCode
3 participants