Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: [Resolver] Error when parsing the JSON response on success #5234

Open
1 task done
enyst opened this issue Nov 24, 2024 · 3 comments
Open
1 task done

[Bug]: [Resolver] Error when parsing the JSON response on success #5234

enyst opened this issue Nov 24, 2024 · 3 comments
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands resolver Related to OpenHands Resolver

Comments

@enyst
Copy link
Collaborator

enyst commented Nov 24, 2024

Is there an existing issue for the same bug?

  • I have checked the existing issues.

Describe the bug and reproduction steps

This seems to happen all the time: (I think? I don't see a successful comment even if the agent did solve the task, please let me know if I'm doing something wrong, I'm not too familiar with the resolver ❤️ )

NOTE: the issue is that success_explanation fails parsing as JSON.

06:13:25 - openhands:ERROR: resolve_issue.py:260 - Failed to parse success_explanation as JSON: The feedback has not been successfully resolved. Looking at the thread, there are several key points:

Example:
https://github.com/All-Hands-AI/OpenHands/actions/runs/11993727601/job/33434996319#step:10:696

  • the critique response is not present in a comment
Looking at the thread, there are several key points:...
  • the extra text is nowhere to be found either, I mean this text:
06:13:25 - openhands:INFO: resolve_issue.py:273 - I have updated the PR and resolved some of the issues that were cited in the pull request review. Specifically, I identified the following revision requests, and all the ones that I think I successfully resolved are checked off. All the unchecked ones I was not able to resolve, so manual intervention may be required:

- [ ]: The feedback has not been successfully resolved. Looking at the thread, there are several key points:

OpenHands Installation

Other

OpenHands Version

No response

Operating System

None

Logs, Errors, Screenshots, and Additional Context

No response

@enyst enyst added the bug Something isn't working label Nov 24, 2024
@enyst
Copy link
Collaborator Author

enyst commented Nov 24, 2024

This might be related to or a duplicate of #5216

@mamoodi mamoodi added the resolver Related to OpenHands Resolver label Nov 25, 2024
@enyst enyst added the fix-me Attempt to fix this issue with OpenHands label Nov 27, 2024
Copy link
Contributor

OpenHands started fixing the issue! You can monitor the progress here.

Copy link
Contributor

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-5234' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix-me Attempt to fix this issue with OpenHands resolver Related to OpenHands Resolver
Projects
None yet
Development

No branches or pull requests

2 participants