Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] how to provide a grpc API test framework #474

Closed
allencloud opened this issue Jan 2, 2018 · 2 comments
Closed

[feature request] how to provide a grpc API test framework #474

allencloud opened this issue Jan 2, 2018 · 2 comments
Assignees
Labels
areas/test kind/feature kind/feature-request This is a feature request from community for PouchContainer kind/question all questions or confusion about this project priority/P2

Comments

@allencloud
Copy link
Collaborator

allencloud commented Jan 2, 2018

Issue Description

We have started the CRI implementation plan in Pouch. And in the previous PRs #426 and #455 we have initially make pod sandbox creation work.

As the developing work goes on, we still need to finish the CRI test work. Currently we need to add two parts of CRI test type:

  • unit test in added CRI related codes;
  • integration test for CRI API which is based on grpc.

In the future, after release of pouch's 1.0 version, we need to add performance test and stablility test and other aspects of testing.

So, right now, we should improve the priority of API integration test for CRI grpc server. Since when we start a pouch daemon, it also listens to a port which is reserved for grpc, we can add grpc integration test cases directly in /test.

Here we need to add a grpc test framework for grpc and add test cases for API. I think we had better make test case addition easily like HTTP API test case's we have done right now.

/cc @Letty5411 @YaoZengzeng

Describe what happened:
No CRI grpc test added.

Describe what you expected to happen:
Finish unit test in CRI related code and provide a grpc test framework to add API integration test.

Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added areas/test kind/feature kind/feature-request This is a feature request from community for PouchContainer kind/question all questions or confusion about this project labels Jan 2, 2018
@allencloud allencloud added this to the v0.1-Milestone milestone Jan 2, 2018
@allencloud
Copy link
Collaborator Author

We will consider use https://github.com/kubernetes-incubator/cri-tools as integration test tools. But here I have concern if it is suitable for an initial project like pouch which just finishes a little part of CRI implementation. @Letty5411 @YaoZengzeng @skoo87

@YaoZengzeng
Copy link
Contributor

@allencloud Maybe we can use option "--focus" to limit the scope of test.

https://github.com/kubernetes-incubator/cri-tools/blob/master/docs/validation.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/test kind/feature kind/feature-request This is a feature request from community for PouchContainer kind/question all questions or confusion about this project priority/P2
Projects
None yet
Development

No branches or pull requests

5 participants