Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] We cannot see any metrics about gRPC which used in cri package #2414

Closed
fengzixu opened this issue Nov 2, 2018 · 2 comments
Closed
Labels
kind/bug This is bug report for project

Comments

@fengzixu
Copy link
Contributor

fengzixu commented Nov 2, 2018

Ⅰ. Issue Description

When I resolved this issue #2395 , I revised the logic about metrics in cri package. I found that GRPCMetrics(https://github.com/alibaba/pouch/blob/master/cri/metrics/metrics.go#L23) was used in https://github.com/alibaba/pouch/blob/1f7dbf60d406210c65fb96ea4682f6d04f97773e/cri/v1alpha2/service/cri.go#L21 . But, the GRPCMetrics wasn't registered to defaultPrometheusRegistry or customPrometheusRegistry.

Ⅱ. Describe what happened

  1. GRPCMetrics wasn't registered
  2. Not found any metric about gRPC

Ⅲ. Describe what you expected to happen

We should register GRPCMetrics to registry about Prometheus. After that, we can see the metrics through curl http://xxx/metrics

Ⅳ. How to reproduce it (as minimally and precisely as possible)

If someone can help me to identify this bug, I will revise it together with #2395.

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added the kind/bug This is bug report for project label Nov 2, 2018
@fengzixu fengzixu changed the title [bug] There is no any metrics about gRPC in cri package [bug] We can see any metrics about gRPC which used in cri package Nov 2, 2018
@fengzixu fengzixu changed the title [bug] We can see any metrics about gRPC which used in cri package [bug] We cannot see any metrics about gRPC which used in cri package Nov 2, 2018
@starnop
Copy link
Contributor

starnop commented Nov 5, 2018

At present, GRPCMetrics is not necessary actually, so delete it firstly. Sorry for forgot to add a TODO tag. Maybe you can help add it or make it registered. THX.

@fengzixu
Copy link
Contributor Author

fengzixu commented Nov 5, 2018

@starnop OK. I will delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is bug report for project
Projects
None yet
Development

No branches or pull requests

3 participants