Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] make lxcfs configurable supportd in CRI managers for Kubernetes #2172

Closed
starnop opened this issue Aug 29, 2018 · 2 comments · Fixed by #2210
Closed

[feature request] make lxcfs configurable supportd in CRI managers for Kubernetes #2172

starnop opened this issue Aug 29, 2018 · 2 comments · Fixed by #2210
Labels
areas/orchestration kind/feature kind/feature-request This is a feature request from community for PouchContainer status/more-info-needed

Comments

@starnop
Copy link
Contributor

starnop commented Aug 29, 2018

Ⅰ. Issue Description

Currently, PouchContainer has supported resource review isolation via lxcfs, While actually in kubernetes, there is no related API to support these feature.

In order to implement this, I think we have to support these parameters in annotations in CRI manager(CRI implementation of PouchContainer).

When CRI manager deals the annotation details, it could pass these parameters to container manager, and container manager definitely implement these features very well.

So, we need to accomplish the following things:

  • define the specific naming in annotations for each feature;
  • implement the transformation in CRI manager and pass them to container manager.

Ⅱ. Describe what happened

Ⅲ. Describe what you expected to happen

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

  • pouch version (use pouch version):
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@pouchrobot pouchrobot added kind/feature kind/feature-request This is a feature request from community for PouchContainer labels Aug 29, 2018
@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @starnop
While we thought ISSUE TITLE could be more specific, longer than 20 chars.
Please edit issue title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@starnop starnop changed the title [feature request] [feature request]make lxcfs configurable supportd in CRI managers for Kubernetes Aug 29, 2018
@allencloud allencloud changed the title [feature request]make lxcfs configurable supportd in CRI managers for Kubernetes [feature request] make lxcfs configurable supportd in CRI managers for Kubernetes Aug 29, 2018
@starnop
Copy link
Contributor Author

starnop commented Aug 30, 2018

we could have the following definition:

{"io.kubernetes.lxcfs.enabled": "true"} means we need to enable lxcfs for a container;

@allencloud WDTY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
areas/orchestration kind/feature kind/feature-request This is a feature request from community for PouchContainer status/more-info-needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants