Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Indicators Creation on StixExport.py #10

Open
pe3zx opened this issue Jun 19, 2017 · 0 comments
Open

Duplicate Indicators Creation on StixExport.py #10

pe3zx opened this issue Jun 19, 2017 · 0 comments

Comments

@pe3zx
Copy link

pe3zx commented Jun 19, 2017

I have tired to implement STIX for AlienVault OTX by myself, to learn how to use python-stix and cybox modules, and I used StixExport.py as a template.

According to the process to create a new indicator, for example, a URL indicator, an observable_ will be added to a new indicator and then a new indicator will be added to a package. When this process is done, <indicator:Title> and <indicator:Description> will contain information from mind.

mind = Indicator()
mind.description = p_indicator["description"]
mind.title = "%s from %spulse/%s" % (p_indicator["indicator"], PULSE_SERVER_BASE, str(self.pulse["id"]))
observable_.title = "%s - %s" % (p_indicator["type"], p_indicator["indicator"])
mind.add_observable(observable_)
self.stix_package.add_indicator(mind)

By the way, SitxExport.py also has another part that responsible to create and add information to an indicator new_ind, but new_ind are not going to use on any part of code. Please clarify me why it needs to create both new_ind and mind when only mind is used.

...
new_ind = Indicator()
new_ind.description = p_indicator["description"]
...
@pe3zx pe3zx changed the title Duplicate Indicators Creation on StixExpert.py Duplicate Indicators Creation on StixExport.py Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant