Fixes for MID decoding and data access #8612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstocco
approved these changes
Apr 19, 2022
dstocco
reviewed
Apr 19, 2022
| auto getBCDiff = [startIR = this->startIR](const o2::InteractionRecord& ir) { | ||
| static int BCDiffErrCount = 0; | ||
| constexpr int MAXBCDiffErrCount = 5; | ||
| auto bcd = ir.differenceInBC(startIR); | ||
| if (uint64_t(bcd) > o2::constants::lhc::LHCMaxBunches * 256 && BCDiffErrCount < MAXBCDiffErrCount) { |
There was a problem hiding this comment.
Are you assuming that the number of orbits per TF is 256? Isn't it 128 now?
There was a problem hiding this comment.
256 is the max we can have though in real data production we will likely have only 128 (but e.g. MC currently uses 256). To be rigorous, one should take the real NHBFperTF from the GRP, but I did not want to make RecoContainerCreateTracksVariadic on CCDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.