Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLO: QC: Add 3d plot and widen eta cuts #13692

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

f3sch
Copy link
Collaborator

@f3sch f3sch commented Nov 14, 2024

Allows to set the number of pt bin+range, eta cuts and sets 'reasonable' defaults in the params.
The efficiency needs to be calculated in a post-process step since TEfficiency is not projectable into smaller dim.

Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@f3sch
Copy link
Collaborator Author

f3sch commented Nov 26, 2024

pinging @mfaggin as a small reminder

Copy link
Contributor

@mfaggin mfaggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @f3sch , all looks ok to me. Just a couple of comments (not stopper at all):

  • you remove lines 1178-1197. This was just a consistency check between numerator and denominator. If you found it unnecessary in your local tests then I think it's ok to remove it, otherwise keeping it it's not dangerous (in case of unexpected issues, it just drops a meaningful error)
  • just an obvious reminder: since you change some cuts as we discussed (e.g. etaITS<0.9 --> etaITS<1.4), and you introduce some objects with higher dimentions (TH3) you have to remember to change the postprocessing accordingly to be able to produce plots with different eta (phi) ranges.

@f3sch f3sch marked this pull request as ready for review November 27, 2024 07:45
@f3sch f3sch requested review from shahor02 and a team as code owners November 27, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants