Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in stopping track accumulation when stat is ok #10733

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Fix in stopping track accumulation when stat is ok #10733

merged 2 commits into from
Feb 8, 2023

Conversation

shahor02
Copy link
Collaborator

@shahor02 shahor02 commented Feb 8, 2023

@martenole
Copy link
Contributor

Thanks @shahor02 but actually one should not break here in case additional ITS-TPC tracks are requested. The segfault occurred, because with the default settings ITS-TPC tracks are not requested. And in any case there must be a protection in case no ITS-TPC tracks are available for a given TF.
But if there are, then I don't stop even if a sufficient amount of statistics is already reached. Instead, I still process a certain number of ITS-TPC only tracks to get a more uniform phi coverage

@martenole martenole merged commit ea8fda3 into AliceO2Group:dev Feb 8, 2023
@shahor02 shahor02 deleted the pr_fixTPCInt branch February 13, 2023 14:13
This was referenced Feb 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahor02 @martenole