Fix TRD refit LT-integral calculation and material accounting #10509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
davidrohr,
f3sch,
bazinski,
tdietel and
martenole
as code owners
|
Dependence of the L-integral on the outer param X: |
|
Hi @shahor02, |
martenole
reviewed
Dec 21, 2022
| @@ -97,6 +97,7 @@ AddOptionRTC(trkltResRPhiIdeal, float, 1.f, "", 0, "Optimal tracklet rphi resolu | |||
| AddOptionRTC(applyDeflectionCut, unsigned char, 0, "", 0, "Set to 1 to enable tracklet selection based on deflection") | |||
| AddOptionRTC(stopTrkAfterNMissLy, unsigned char, 6, "", 0, "Abandon track following after N layers without a TRD match") | |||
| AddOptionRTC(useExternalO2DefaultPropagator, unsigned char, 0, "", 0, "Use the default instance of the o2::Propagator, instead of the GPU Reconstruciton one with GPU B field") | |||
| AddOptionRTC(matCorrType, int, 2, "", 0, "Material correction to use: 0 - none, 1 - TGeo, 2 - matLUT") | |||
There was a problem hiding this comment.
Ah, I think it would be better to use an unsigned char here instead, or move the option up above the first char one. Maybe @davidrohr can confirm, but if I remember correctly then the order of the options here is not arbitrary because of the alignment in memory.
There was a problem hiding this comment.
sure, changed to uint.
shahor02
force-pushed
the
pr_trdLTint
branch
from
edb62b1 to
793f279
Compare
martenole
approved these changes
Dec 21, 2022
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.