ITS Calib: compatibility with data produced with IB commissioning tools #10505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravasen
requested review from
iouribelikov,
bovulpes,
rpezzi and
mconcas
as code owners
|
Hi @shahor02, can I kindly ask you to merge this PR when you have 2s, please? Thanks a lot in advance. |
mconcas
approved these changes
Jan 11, 2023
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Jan 17, 2023
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to process data on disk obtained with CRU_ITS -> IB commissioning tools (https://gitlab.cern.ch/alice-its-wp10-firmware/CRU_ITS/-/blob/production/software/py/ib_tools/README.md).
The main changes here are due to the different format of the calibration word which is generated with those tools and to the different number of injections per charge (25).
Flag
--enable-cru-itsallow to activate the processing of this data while the option--ninjallow to set the number of injections per charge point which is 50 by default.