Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS-tracking::Async: optionally discard whole TF instead of breaking #13791

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Dec 11, 2024

  • Add option to drop the whole TF and continue

@mconcas mconcas requested a review from shahor02 as a code owner December 11, 2024 11:06
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@mconcas
Copy link
Collaborator Author

mconcas commented Dec 11, 2024

@shahor02 @mpuccio
First commit will add the possibility to drop the full TF.
Later I'll implement the possibility to drop the slice of ROFs only.

@mconcas
Copy link
Collaborator Author

mconcas commented Dec 11, 2024

@shahor02 @mpuccio First commit will add the possibility to drop the full TF. Later I'll implement the possibility to drop the slice of ROFs only.

Update: dropping data related to the single slice is super-fragile and error prone. I have a tentative implementation one can discuss, but I think for the moment we can just survive with this simpler and robust approach.

Will merge upon your approvals, @shahor02 @mpuccio

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mconcas !
See below. Did you test the both options?

Detectors/ITSMFT/ITS/tracking/src/TimeFrame.cxx Outdated Show resolved Hide resolved
Detectors/ITSMFT/ITS/tracking/src/Tracker.cxx Outdated Show resolved Hide resolved
@mconcas
Copy link
Collaborator Author

mconcas commented Dec 12, 2024

Did you test the both options?

In case ITSCATrackerParam.fataliseUponFailure=false we can choose if we want to keep the tracks from previous successful iterations by setting ITSCATrackerParam.dropTFUponFailure=false or to drop the full TF, by setting the former to true. both cases work.
Setting ITSCATrackerParam.fataliseUponFailure=true will restore the normal behaviour, regardless of the other option, of course.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 4c8aefe at 2024-12-12 12:10:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13791-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13791-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/b64e8da06eb0efa720a1e3eacf246ef338d4b8db/slc8_x86-64/o2checkcode/1.0-local758/etc/modulefiles
++ cat
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 12, 2024

Error while checking build/O2/fullCI for 115cfaa at 2024-12-12 14:59:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13791-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13791-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/54528a023afaaff4688be5395c8982e23932dda1/slc8_x86-64/o2checkcode/1.0-local372/etc/modulefiles
++ cat
--

Full log here.

@mconcas mconcas merged commit 4f42cba into AliceO2Group:dev Dec 12, 2024
7 of 11 checks passed
@mconcas mconcas deleted the pr_drop_tf branch December 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants