-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix on destructors not being called by o2sim #13769
Conversation
Fundamental to be able to kill the child process spawned by CMD functionality of GeneratorFileOrCmd generator. This was not so useful when the destructors were not called at the end of the simulation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Error while checking build/O2/fullCI for 03913e4 at 2024-12-09 08:06:
Full log here. |
GeneratorService is failing, the PR requires more adjustments, not to be merged for the moment |
Error while checking build/O2/fullCI for 22bfb67 at 2024-12-11 17:38:
Full log here. |
Setting [WIP] in the PR title. O2sim tests work, but GeneratorService test fails and more debug is needed. |
Cleanup function called manually in main simulation programs
Please consider the following formatting changes to AliceO2Group#13769
Closing. Alternative PR #13817 merged. |
Most generators destructors are default ones, however by using the HepMC generator I noticed that the destructor was not called when the simulation terminates. This called for a series of modifications: