From 0c6b3254bccc7c17542f3da0b6fe6db4630dabd8 Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Wed, 29 Mar 2017 21:13:01 +0200 Subject: [PATCH 1/6] Add issue and pull request templates --- .github/ISSUE_TEMPLATE.md | 24 ++++++++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE.md | 13 +++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE.md create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md new file mode 100644 index 00000000..dcf50848 --- /dev/null +++ b/.github/ISSUE_TEMPLATE.md @@ -0,0 +1,24 @@ +### New Issue Checklist + +- [ ] I have tried with the latest version of OHHTTPStubs +- [ ] I have read the [README](https://github.com/AliSoftware/OHHTTPStubs/blob/master/README.md) +- [ ] I have read the [Using the right Swift Version of `OHHTTPStubs` for your project](https://github.com/AliSoftware/OHHTTPStubs#using-the-right-swift-version-of-ohhttpstubs-for-your-project) section +- [ ] I have searched in the [existing issues](https://github.com/AliSoftware/OHHTTPStubs/issues?utf8=✓&q=is%3Aissue) + +### Environment + +- version of OHHTTPStubs: [LIB VERSION HERE] +- integration method you are using: + * [ ] Cocoapods + * [ ] Carthage + * [ ] submodule + * [ ] other +- version of the tool you use: [INSERT VERSION HERE] + +### Issue Description + +[DESCRIBE YOUR ISSUE HERE] + +##### Complete output when you encounter the issue (if any) + +[INSERT OUTPUT HERE] diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..e92885cd --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,13 @@ + + +### Checklist +- [ ] I've checked that all new and existing tests pass. +- [ ] I've updated the documentation if necessary. + +### Description + + +### Motivation and Context + + + From a536b39836fe1b369f9bcb5d88bd6fa62924e744 Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Wed, 29 Mar 2017 22:42:13 +0200 Subject: [PATCH 2/6] Review --- .github/ISSUE_TEMPLATE.md | 5 ++++- .github/PULL_REQUEST_TEMPLATE.md | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index dcf50848..604327bb 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,9 +1,12 @@ + + ### New Issue Checklist - [ ] I have tried with the latest version of OHHTTPStubs - [ ] I have read the [README](https://github.com/AliSoftware/OHHTTPStubs/blob/master/README.md) - [ ] I have read the [Using the right Swift Version of `OHHTTPStubs` for your project](https://github.com/AliSoftware/OHHTTPStubs#using-the-right-swift-version-of-ohhttpstubs-for-your-project) section - [ ] I have searched in the [existing issues](https://github.com/AliSoftware/OHHTTPStubs/issues?utf8=✓&q=is%3Aissue) +- [ ] I have read [the OHHTTPStubs wiki](https://github.com/AliSoftware/OHHTTPStubs/wiki) to see if there wasn't a detailed page talking about my issue ### Environment @@ -21,4 +24,4 @@ ##### Complete output when you encounter the issue (if any) -[INSERT OUTPUT HERE] +```[INSERT OUTPUT HERE]``` diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index e92885cd..04658ead 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,13 +1,17 @@ ### Checklist + - [ ] I've checked that all new and existing tests pass. - [ ] I've updated the documentation if necessary. +- [ ] I've added an entry in the CHANGELOG to credit myself ### Description + ### Motivation and Context + From 2558d7fea4349dc4917e05143810b2134941afa2 Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Wed, 29 Mar 2017 22:54:17 +0200 Subject: [PATCH 3/6] Remove formatting in HTML comments in templates --- .github/ISSUE_TEMPLATE.md | 2 +- .github/PULL_REQUEST_TEMPLATE.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 604327bb..8de03ce0 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,4 @@ - + ### New Issue Checklist diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 04658ead..9bf0c838 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ - + ### Checklist From 63f51f3f812fa0ab02262401a3163fd625080d2e Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Wed, 29 Mar 2017 23:03:13 +0200 Subject: [PATCH 4/6] Change wording in template's comment --- .github/ISSUE_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 8de03ce0..932eb4af 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -1,4 +1,4 @@ - + ### New Issue Checklist From 05fecfc2dcc7cce7275519ef18b40891cdf5ab45 Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Thu, 30 Mar 2017 08:12:09 +0200 Subject: [PATCH 5/6] Remove trailing dots in template's checklists --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 9bf0c838..20f29803 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,8 +2,8 @@ ### Checklist -- [ ] I've checked that all new and existing tests pass. -- [ ] I've updated the documentation if necessary. +- [ ] I've checked that all new and existing tests pass +- [ ] I've updated the documentation if necessary - [ ] I've added an entry in the CHANGELOG to credit myself ### Description From b86aa3a97ab3b73e36591842d9a9079f090312b4 Mon Sep 17 00:00:00 2001 From: Liquidsoul Date: Thu, 30 Mar 2017 08:13:32 +0200 Subject: [PATCH 6/6] Fix output quoting in issue template --- .github/ISSUE_TEMPLATE.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 932eb4af..fed0db5d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -24,4 +24,6 @@ ##### Complete output when you encounter the issue (if any) -```[INSERT OUTPUT HERE]``` +``` +[INSERT OUTPUT HERE] +```