fix(fetch): always call revalidateCallback

Alwatr · Dec 13, 2022 · 444edc5 · 444edc5
1 parent dfbbc00
commit 444edc5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/fetch/src/fetch.ts b/core/fetch/src/fetch.ts
@@ -170,7 +170,7 @@ async function _handleCacheStrategy(options: Required<FetchOptions>): Promise<Re
       const fetchedResponsePromise = _handleRemoveDuplicate(options).then((networkResponse) => {
         if (networkResponse.ok) {
           cacheStorage.put(request, networkResponse.clone());
-          if (cachedResponse != null && typeof options.revalidateCallback === 'function') {
+          if (typeof options.revalidateCallback === 'function') {
             options.revalidateCallback(networkResponse);
           }
         }

diff --git a/core/fetch/src/type.ts b/core/fetch/src/type.ts
@@ -68,7 +68,7 @@ export interface FetchOptions extends RequestInit {
   /**
    * Revalidate callback for `stale_while_revalidate` cache strategy.
    */
-  revalidateCallback?: (response: Response) => void;
+  revalidateCallback?: (response: Response) => void | Promise<void>;
 
   /**
    * Cache storage custom name.