Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outline icons prevent from moving to Material Symbols #8679

Closed
romainbrochot opened this issue Jun 19, 2023 · 5 comments
Closed

Outline icons prevent from moving to Material Symbols #8679

romainbrochot opened this issue Jun 19, 2023 · 5 comments

Comments

@romainbrochot
Copy link

Type of issue: (check with "[x]")

  • New feature request
  • Bug
  • Support request
  • Documentation

Current behaviour:
Some icons use the outline "flag". example : info_outline and with Material Symbols they are not displayed properly.

Expected behavior:
Use CSS classes instead so we can register our own classes in the module with the MatIconRegistry service.

Steps to reproduce the issue:
Remove material icons from custom-styles.scss
Add material symbols instead.
ADF components using "_outline" icons are not displayed properly.

Component name and version:

Browser and version:

Node version (for build issues):

New feature request:
Add the possibility to use Mat Symbols

@DenysVuika
Copy link
Contributor

the work for outlined icons is still in progress #8640
what custom-styles.scss do you refer to?

@romainbrochot
Copy link
Author

Sorry I forgot to add we removed MatIcons http resource in index.html and we use npm dependency for material icons and we import it from custom-styles.scss in our projects because of customers not allowing internet access on their servers

@DenysVuika
Copy link
Contributor

We are still sticking to the Material Icons for now, but you might be interested to see how we are going to use outlined icons or custom font sets in ACA: Alfresco/alfresco-content-app#3283

Essentially, you can override the default fontSet like this:

export class AppModule {
  constructor(matIconRegistry: MatIconRegistry) {
    matIconRegistry.setDefaultFontSetClass('material-icons-outlined');
  }
}

@romainbrochot
Copy link
Author

Yes that's how we did it. It's just that, in specific ADF components, outlined icons do not display properly if we use something else than mat icons.
We'll stick to Mat icons until your work is finished.
You can close the case.

@DenysVuika
Copy link
Contributor

thanks for confirming. Switching to Material Symbols will be a breaking change in terms of backwards compatibility, but it is possible using outlined icons with Material Icons too. Closing for now and we might get back to that in the future releases if we decide migrating to Symbols

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants