diff --git a/e2e/components/dialog/create-library-dialog.ts b/e2e/components/dialog/create-library-dialog.ts new file mode 100755 index 0000000000..074d5beeba --- /dev/null +++ b/e2e/components/dialog/create-library-dialog.ts @@ -0,0 +1,173 @@ +/*! + * @license + * Alfresco Example Content Application + * + * Copyright (C) 2005 - 2018 Alfresco Software Limited + * + * This file is part of the Alfresco Example Content Application. + * If the software was purchased under a paid Alfresco license, the terms of + * the paid license agreement will prevail. Otherwise, the software is + * provided under the following open source license terms: + * + * The Alfresco Example Content Application is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * The Alfresco Example Content Application is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with Alfresco. If not, see . + */ + +import { ElementFinder, by, browser, protractor, ExpectedConditions as EC } from 'protractor'; +import { BROWSER_WAIT_TIMEOUT } from '../../configs'; +import { Component } from '../component'; +import { Utils } from '../../utilities/utils'; + +export class CreateLibraryDialog extends Component { + private static selectors = { + root: 'app-library-dialog', + + title: '.mat-dialog-title', + nameInput: 'input[placeholder="Name" i]', + libraryIdInput: 'input[placeholder="Library ID" i]', + descriptionTextArea: 'textarea[placeholder="Description" i]', + button: '.mat-dialog-actions button', + radioButton: '.mat-radio-label', + radioChecked: 'mat-radio-checked', + errorMessage: '.mat-error' + }; + + title: ElementFinder = this.component.element(by.css(CreateLibraryDialog.selectors.title)); + nameInput: ElementFinder = this.component.element(by.css(CreateLibraryDialog.selectors.nameInput)); + libraryIdInput: ElementFinder = this.component.element(by.css(CreateLibraryDialog.selectors.libraryIdInput)); + descriptionTextArea: ElementFinder = this.component.element(by.css(CreateLibraryDialog.selectors.descriptionTextArea)); + visibilityPublic: ElementFinder = this.component.element(by.cssContainingText(CreateLibraryDialog.selectors.radioButton, 'Public')); + visibilityModerated: ElementFinder = this.component.element(by.cssContainingText(CreateLibraryDialog.selectors.radioButton, 'Moderated')); + visibilityPrivate: ElementFinder = this.component.element(by.cssContainingText(CreateLibraryDialog.selectors.radioButton, 'Private')); + createButton: ElementFinder = this.component.element(by.cssContainingText(CreateLibraryDialog.selectors.button, 'Create')); + cancelButton: ElementFinder = this.component.element(by.cssContainingText(CreateLibraryDialog.selectors.button, 'Cancel')); + errorMessage: ElementFinder = this.component.element(by.css(CreateLibraryDialog.selectors.errorMessage)); + + constructor(ancestor?: ElementFinder) { + super(CreateLibraryDialog.selectors.root, ancestor); + } + + async waitForDialogToOpen() { + await browser.wait(EC.presenceOf(this.title), BROWSER_WAIT_TIMEOUT); + await browser.wait(EC.presenceOf(browser.element(by.css('.cdk-overlay-backdrop'))), BROWSER_WAIT_TIMEOUT); + } + + async waitForDialogToClose() { + await browser.wait(EC.stalenessOf(this.title), BROWSER_WAIT_TIMEOUT); + } + + async isDialogOpen() { + return await browser.isElementPresent(by.css(CreateLibraryDialog.selectors.root)); + } + + async getTitle() { + return await this.title.getText(); + } + + async isErrorMessageDisplayed() { + return await this.errorMessage.isDisplayed(); + } + + async getErrorMessage() { + await this.isErrorMessageDisplayed(); + return await this.errorMessage.getText(); + } + + async isNameDisplayed() { + return await this.nameInput.isDisplayed(); + } + + async isLibraryIdDisplayed() { + return await this.libraryIdInput.isDisplayed(); + } + + async isDescriptionDisplayed() { + return await this.descriptionTextArea.isDisplayed(); + } + + async isPublicDisplayed() { + return await this.visibilityPublic.isDisplayed(); + } + + async isModeratedDisplayed() { + return await this.visibilityModerated.isDisplayed(); + } + + async isPrivateDisplayed() { + return await this.visibilityPrivate.isDisplayed(); + } + + async enterName(name: string) { + await this.nameInput.clear(); + await Utils.typeInField(this.nameInput, name); + } + + async enterLibraryId(id: string) { + await this.libraryIdInput.clear(); + await Utils.typeInField(this.libraryIdInput, id); + } + + async enterDescription(description: string) { + await this.descriptionTextArea.clear(); + await Utils.typeInField(this.descriptionTextArea, description); + } + + async deleteNameWithBackspace() { + await this.nameInput.clear(); + await this.nameInput.sendKeys(' ', protractor.Key.CONTROL, 'a', protractor.Key.NULL, protractor.Key.BACK_SPACE); + } + + async isCreateEnabled() { + return await this.createButton.isEnabled(); + } + + async isCancelEnabled() { + return await this.cancelButton.isEnabled(); + } + + async clickCreate() { + await this.createButton.click(); + } + + async clickCancel() { + await this.cancelButton.click(); + await this.waitForDialogToClose(); + } + + async isPublicChecked() { + const elemClass = await this.visibilityPublic.element(by.xpath('..')).getAttribute('class'); + return await elemClass.includes(CreateLibraryDialog.selectors.radioChecked); + } + + async isModeratedChecked() { + const elemClass = await this.visibilityModerated.element(by.xpath('..')).getAttribute('class'); + return await elemClass.includes(CreateLibraryDialog.selectors.radioChecked); + } + + async isPrivateChecked() { + const elemClass = await this.visibilityPrivate.element(by.xpath('..')).getAttribute('class'); + return await elemClass.includes(CreateLibraryDialog.selectors.radioChecked); + } + + async selectPublic() { + await this.visibilityPublic.click(); + } + + async selectModerated() { + await this.visibilityModerated.click(); + } + + async selectPrivate() { + await this.visibilityPrivate.click(); + } +} diff --git a/e2e/components/sidenav/sidenav.ts b/e2e/components/sidenav/sidenav.ts index ad185db1fe..936f5418f7 100755 --- a/e2e/components/sidenav/sidenav.ts +++ b/e2e/components/sidenav/sidenav.ts @@ -56,11 +56,16 @@ export class Sidenav extends Component { await menu.waitForMenuToOpen(); } - async openCreateDialog() { + async openCreateFolderDialog() { await this.openNewMenu(); await this.menu.clickMenuItem('Create folder'); } + async openCreateLibraryDialog() { + await this.openNewMenu(); + await this.menu.clickMenuItem('Create Library'); + } + async isActiveByLabel(label: string) { const className = await this.getLinkByLabel(label).getAttribute('class'); return className.includes(Sidenav.selectors.activeLink.replace('.', '')); diff --git a/e2e/suites/actions/create-folder.test.ts b/e2e/suites/actions/create-folder.test.ts index f7cd520473..1dec61ebe0 100755 --- a/e2e/suites/actions/create-folder.test.ts +++ b/e2e/suites/actions/create-folder.test.ts @@ -92,7 +92,7 @@ describe('Create folder', () => { it('creates new folder with name - [C216341]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(folderName1); await createDialog.clickCreate(); @@ -104,7 +104,7 @@ describe('Create folder', () => { it('creates new folder with name and description - [C216340]', async (done) => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(folderName2); await createDialog.enterDescription(folderDescription); @@ -126,7 +126,7 @@ describe('Create folder', () => { it('dialog UI elements - [C216345]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); const dialogTitle = await createDialog.getTitle(); const isFolderNameDisplayed = await createDialog.nameInput.isDisplayed(); @@ -143,7 +143,7 @@ describe('Create folder', () => { it('with empty folder name - [C216346]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.deleteNameWithBackspace(); const isCreateEnabled = await createDialog.createButton.isEnabled(); @@ -155,7 +155,7 @@ describe('Create folder', () => { it('with folder name ending with a dot "." - [C216348]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName('folder-name.'); const isCreateEnabled = await createDialog.createButton.isEnabled(); @@ -169,7 +169,7 @@ describe('Create folder', () => { const namesWithSpecialChars = [ 'a*a', 'a"a', 'aa', `a\\a`, 'a/a', 'a?a', 'a:a', 'a|a' ]; await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); for (const name of namesWithSpecialChars) { @@ -181,7 +181,7 @@ describe('Create folder', () => { it('with folder name containing only spaces - [C280406]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(' '); const isCreateEnabled = await createDialog.createButton.isEnabled(); @@ -193,7 +193,7 @@ describe('Create folder', () => { it('cancel folder creation - [C216349]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName('test'); await createDialog.enterDescription('test description'); @@ -203,7 +203,7 @@ describe('Create folder', () => { it('duplicate folder name - [C216350]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(duplicateFolderName); await createDialog.clickCreate(); @@ -214,7 +214,7 @@ describe('Create folder', () => { it('trim ending spaces from folder name - [C216351]', async () => { await page.dataTable.doubleClickOnRowByName(parent); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(nameWithSpaces); await createDialog.clickCreate(); diff --git a/e2e/suites/actions/create-library.test.ts b/e2e/suites/actions/create-library.test.ts new file mode 100755 index 0000000000..4d956fb566 --- /dev/null +++ b/e2e/suites/actions/create-library.test.ts @@ -0,0 +1,224 @@ +/*! + * @license + * Alfresco Example Content Application + * + * Copyright (C) 2005 - 2018 Alfresco Software Limited + * + * This file is part of the Alfresco Example Content Application. + * If the software was purchased under a paid Alfresco license, the terms of + * the paid license agreement will prevail. Otherwise, the software is + * provided under the following open source license terms: + * + * The Alfresco Example Content Application is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * The Alfresco Example Content Application is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with Alfresco. If not, see . + */ + +import { browser } from 'protractor'; +import { SITE_VISIBILITY } from '../../configs'; +import { LoginPage, BrowsingPage } from '../../pages/pages'; +import { CreateLibraryDialog } from '../../components/dialog/create-library-dialog'; +import { Menu } from '../../components/menu/menu'; +import { Utils } from '../../utilities/utils'; +import { RepoClient } from '../../utilities/repo-client/repo-client'; + +describe('Create library', () => { + const username = `user-${Utils.random()}`; + + const site1Name = `site1-${Utils.random()}`; + const site2Name = `site2-${Utils.random()}`; + const site3Name = `site3-${Utils.random()}`; + + const site4 = { + name: `site4-${Utils.random()}`, + id: `site4-id-${Utils.random()}`, + description: 'site4 description' + } + + const duplicateSite = { + name: `duplicate-${Utils.random()}`, + id: `duplicate-${Utils.random()}` + } + + const siteInTrash = { + name: `site-trash-${Utils.random()}`, + id: `site-trash-id-${Utils.random()}` + } + + const apis = { + admin: new RepoClient(), + user: new RepoClient(username, username) + }; + + const loginPage = new LoginPage(); + const page = new BrowsingPage(); + const createDialog = new CreateLibraryDialog(); + const menu = new Menu(); + const { dataTable } = page; + + beforeAll(async (done) => { + await apis.admin.people.createUser({ username }); + await apis.user.sites.createSite(duplicateSite.name, SITE_VISIBILITY.PRIVATE, '', duplicateSite.id); + await apis.user.sites.createSite(siteInTrash.name, SITE_VISIBILITY.PUBLIC, '', siteInTrash.id); + await apis.user.sites.deleteSite(siteInTrash.id, false); + + await loginPage.loginWith(username); + done(); + }); + + afterEach(async (done) => { + await Utils.pressEscape(); + done(); + }); + + afterAll(async (done) => { + await apis.user.sites.deleteAllUserSites(); + done(); + }); + + it('Create Library dialog UI - [C280024]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + expect(await createDialog.getTitle()).toMatch('Create Library'); + expect(await createDialog.isNameDisplayed()).toBe(true, 'Name input is not displayed'); + expect(await createDialog.isLibraryIdDisplayed()).toBe(true, 'Library ID input is not displayed'); + expect(await createDialog.isDescriptionDisplayed()).toBe(true, 'Description field is not displayed'); + expect(await createDialog.isPublicDisplayed()).toBe(true, 'Public option is not displayed'); + expect(await createDialog.isModeratedDisplayed()).toBe(true, 'Moderated option is not displayed'); + expect(await createDialog.isPrivateDisplayed()).toBe(true, 'Private option is not displayed'); + expect(await createDialog.isPublicChecked()).toBe(true, 'Public option not checked'); + expect(await createDialog.isCreateEnabled()).toBe(false, 'Create button is not disabled'); + expect(await createDialog.isCancelEnabled()).toBe(true, 'Cancel button is not enabled'); + }); + + it('Create a public library - [C280025]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(site1Name); + await createDialog.clickCreate(); + await createDialog.waitForDialogToClose(); + const current = await page.breadcrumb.getCurrentItemName(); + expect(current).toEqual(site1Name, `Not navigated into ${site1Name}`); + await page.clickFileLibrariesAndWait(); + expect(await dataTable.getRowByName(site1Name).isPresent()).toBe(true, `${site1Name} not in the list`); + expect(await apis.user.sites.getVisibility(site1Name)).toEqual(SITE_VISIBILITY.PUBLIC); + }); + + it('Create a moderated library - [C289880]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(site2Name); + await createDialog.selectModerated(); + await createDialog.clickCreate(); + await createDialog.waitForDialogToClose(); + const current = await page.breadcrumb.getCurrentItemName(); + expect(current).toEqual(site2Name, `Not navigated into ${site2Name}`); + await page.clickFileLibrariesAndWait(); + expect(await dataTable.getRowByName(site2Name).isPresent()).toBe(true, `${site2Name} not in the list`); + expect(await apis.user.sites.getVisibility(site2Name)).toEqual(SITE_VISIBILITY.MODERATED); + }); + + it('Create a private library - [C289881]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(site3Name); + await createDialog.selectPrivate(); + await createDialog.clickCreate(); + await createDialog.waitForDialogToClose(); + const current = await page.breadcrumb.getCurrentItemName(); + expect(current).toEqual(site3Name, `Not navigated into ${site3Name}`); + await page.clickFileLibrariesAndWait(); + expect(await dataTable.getRowByName(site3Name).isPresent()).toBe(true, `${site3Name} not in the list`); + expect(await apis.user.sites.getVisibility(site3Name)).toEqual(SITE_VISIBILITY.PRIVATE); + }); + + it('Create a library with a given ID and description - [C289882]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(site4.name); + await createDialog.enterLibraryId(site4.id); + await createDialog.enterDescription(site4.description); + await createDialog.selectPublic(); + await createDialog.clickCreate(); + await createDialog.waitForDialogToClose(); + const current = await page.breadcrumb.getCurrentItemName(); + expect(current).toEqual(site4.name, `Not navigated into ${site4.name}`); + await page.clickFileLibrariesAndWait(); + expect(await dataTable.getRowByName(site4.name).isPresent()).toBe(true, `${site4.name} not in the list`); + expect(await apis.user.sites.getVisibility(site4.id)).toEqual(SITE_VISIBILITY.PUBLIC); + expect(await apis.user.sites.getDescription(site4.id)).toEqual(site4.description); + }); + + it('Duplicate library ID - [C280027]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(duplicateSite.name); + await createDialog.enterLibraryId(duplicateSite.id); + expect(await createDialog.isCreateEnabled()).toBe(false, 'Create button not disabled'); + const err = await createDialog.getErrorMessage(); + expect(err).toEqual(`This Library ID isn't available. Try a different Library ID.`); + }); + + it('Create library using the ID of a library from the Trashcan - [C280028]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(siteInTrash.name); + await createDialog.enterLibraryId(siteInTrash.id); + await createDialog.clickCreate(); + const err = await createDialog.getErrorMessage(); + expect(err).toEqual(`This Library ID is already used. Check the trashcan.`); + }); + + it('Cancel button - [C280029]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName('test site'); + await createDialog.enterDescription('test description'); + await createDialog.clickCancel(); + expect(await createDialog.isDialogOpen()).not.toBe(true, 'dialog is not closed'); + }); + + it('Library ID cannot contain special characters - [C280026]', async () => { + const idWithSpecialChars = [ 'a*a', 'a"a', 'aa', `a\\a`, 'a/a', 'a?a', 'a:a', 'a|a' ]; + + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName('test site'); + + for (const id of idWithSpecialChars) { + await createDialog.enterLibraryId(id); + expect(await createDialog.isCreateEnabled()).toBe(false, 'Create button is not disabled'); + expect(await createDialog.getErrorMessage()).toContain(`Use numbers and letters only`); + } + }); + + it('Create 2 libraries with same name but different IDs - [C280030]', async () => { + await page.sidenav.openCreateLibraryDialog(); + await createDialog.waitForDialogToOpen(); + await createDialog.enterName(duplicateSite.name); + await createDialog.enterLibraryId(`${duplicateSite.id}-2`); + await createDialog.clickCreate(); + await createDialog.waitForDialogToClose(); + const current = await page.breadcrumb.getCurrentItemName(); + expect(current).toEqual(duplicateSite.name, `Not navigated into ${duplicateSite.name}`); + await page.clickFileLibrariesAndWait(); + expect(await dataTable.getRowByName(`${duplicateSite.name} (${duplicateSite.id}-2)`).isPresent()).toBe(true, `${duplicateSite.name} not in the list`); + expect(await apis.user.sites.getTitle(`${duplicateSite.id}-2`)).toEqual(duplicateSite.name); + }); + + it('Tooltip for "Create Library" button - [C286526]', async () => { + await page.sidenav.openNewMenu(); + await browser.actions().mouseMove(menu.getItemByLabel('Create Library')).perform(); + expect(await menu.getItemTooltip('Create Library')).toContain('Create a new File Library'); + }); + +}); diff --git a/e2e/suites/application/general.test.ts b/e2e/suites/application/general.test.ts index 14f9e7f7c0..e9063fe074 100644 --- a/e2e/suites/application/general.test.ts +++ b/e2e/suites/application/general.test.ts @@ -53,7 +53,7 @@ describe('General', () => { it('should close opened dialogs - [C286473]', async () => { await loginPage.loginWithAdmin(); - await page.sidenav.openCreateDialog(); + await page.sidenav.openCreateFolderDialog(); await createDialog.waitForDialogToOpen(); await createDialog.enterName(folder); diff --git a/e2e/utilities/repo-client/apis/sites/sites-api.ts b/e2e/utilities/repo-client/apis/sites/sites-api.ts index 386e11544d..70b3040ddf 100755 --- a/e2e/utilities/repo-client/apis/sites/sites-api.ts +++ b/e2e/utilities/repo-client/apis/sites/sites-api.ts @@ -49,6 +49,21 @@ export class SitesApi extends RepoApi { return (await this.alfrescoJsApi.core.sitesApi.getSiteContainers(siteId)).list.entries[0].entry.id; } + async getVisibility(siteId: string) { + const site = await this.getSite(siteId); + return site.entry.visibility; + } + + async getDescription(siteId: string) { + const site = await this.getSite(siteId); + return site.entry.description; + } + + async getTitle(siteId: string) { + const site = await this.getSite(siteId); + return site.entry.title; + } + async createSite(title: string, visibility?: string, description?: string, siteId?: string) { const site = { title, @@ -80,6 +95,15 @@ export class SitesApi extends RepoApi { }, Promise.resolve()); } + async deleteAllUserSites(permanent: boolean = true) { + const siteIds = (await this.getSites()).list.entries.map(entries => entries.entry.id); + + return await siteIds.reduce(async (previous, current) => { + await previous; + return await this.deleteSite(current, permanent); + }, Promise.resolve()); + } + async updateSiteMember(siteId: string, userId: string, role: string) { const siteRole = { role: role