From 7be5468050b215ab51d7a64e781f65c46820a3c9 Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 09:19:26 +0200 Subject: [PATCH 1/6] [ACS-8886] enable excluded test --- e2e/playwright/authentication/exclude.tests.json | 5 +---- e2e/playwright/folder-rules/exclude.tests.json | 4 +--- e2e/playwright/list-views/exclude.tests.json | 8 +------- e2e/playwright/list-views/src/tests/trash-admin.e2e.ts | 8 +++----- .../manageRules/manage-rules-dialog.component.ts | 2 +- 5 files changed, 7 insertions(+), 20 deletions(-) diff --git a/e2e/playwright/authentication/exclude.tests.json b/e2e/playwright/authentication/exclude.tests.json index cf08a95374..0967ef424b 100644 --- a/e2e/playwright/authentication/exclude.tests.json +++ b/e2e/playwright/authentication/exclude.tests.json @@ -1,4 +1 @@ -{ - "C213097" : "https://alfresco.atlassian.net/browse/ACS-5479", - "C286473" : "https://alfresco.atlassian.net/browse/ACS-5996" -} +{} diff --git a/e2e/playwright/folder-rules/exclude.tests.json b/e2e/playwright/folder-rules/exclude.tests.json index 495a42bc82..0967ef424b 100644 --- a/e2e/playwright/folder-rules/exclude.tests.json +++ b/e2e/playwright/folder-rules/exclude.tests.json @@ -1,3 +1 @@ -{ - "XAT-897": "https://hyland.atlassian.net/browse/ACS-5503" -} +{} diff --git a/e2e/playwright/list-views/exclude.tests.json b/e2e/playwright/list-views/exclude.tests.json index 91d27fbe25..0967ef424b 100644 --- a/e2e/playwright/list-views/exclude.tests.json +++ b/e2e/playwright/list-views/exclude.tests.json @@ -1,7 +1 @@ -{ - "C213217": "https://alfresco.atlassian.net/browse/ACS-6710", - "C213245": "https://alfresco.atlassian.net/browse/ACS-6717", - "C261153": "https://alfresco.atlassian.net/browse/AAE-7517", - "C589205": "https://alfresco.atlassian.net/browse/ACS-6710", - "C261150": "https://alfresco.atlassian.net/browse/ACS-6710" -} +{} diff --git a/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts b/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts index df048beec3..b781f16ab9 100755 --- a/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts +++ b/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts @@ -23,21 +23,19 @@ */ import { expect } from '@playwright/test'; -import { ApiClientFactory, NodesApi, Utils, getUserState, test, TrashcanApi, users } from '@alfresco/aca-playwright-shared'; +import { ApiClientFactory, NodesApi, Utils, getUserState, test, users } from '@alfresco/aca-playwright-shared'; test.use({ storageState: getUserState('admin') }); test.describe('Trash admin', () => { - const folderAdmin = `deleteFolder-${Utils.random()}`; + const folderAdmin = `C213217-deleteFolder-${Utils.random()}`; let folderAdminId: string; let adminApiActions: NodesApi; - let adminTrashcanApi: TrashcanApi; test.beforeAll(async () => { try { const apiClientFactory = new ApiClientFactory(); await apiClientFactory.setUpAcaBackend('admin'); adminApiActions = await NodesApi.initialize('admin'); - adminTrashcanApi = await TrashcanApi.initialize('admin'); folderAdminId = (await adminApiActions.createFolder(folderAdmin)).entry.id; await adminApiActions.deleteNodeById(folderAdminId, false); } catch (error) { @@ -46,7 +44,7 @@ test.describe('Trash admin', () => { }); test.afterAll(async () => { - await Utils.deleteNodesSitesEmptyTrashcan(adminApiActions, adminTrashcanApi, '----- afterAll failed : '); + await adminApiActions.deleteDeletedNode(folderAdminId); }); test.beforeEach(async ({ loginPage }) => { diff --git a/projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules-dialog.component.ts b/projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules-dialog.component.ts index a9ba4e8849..5d34bde6d3 100644 --- a/projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules-dialog.component.ts +++ b/projects/aca-playwright-shared/src/page-objects/components/manageRules/manage-rules-dialog.component.ts @@ -43,7 +43,7 @@ export class ManageRulesDialogComponent extends BaseComponent { public destinationFolderButton = this.getChild('[data-automation-id="card-textitem-clickable-icon-destination-folder"]'); public ruleInBackgroundCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-asynchronous"]'); public ruleSubfoldersCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-inheritable"]'); - public ruleDisableCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-disabled"]'); + public ruleDisableCheckbox = this.getChild('[data-automation-id="rule-option-checkbox-disabled"] input'); public actionsEllipsisButtons = this.getChild('[data-automation-id="rule-action-list-action-menu"]'); public actionsEllipsisDelete = this.page.locator('[data-automation-id="rule-action-list-remove-action-button"]'); public conditionsEllipsisButtons = this.getChild('[data-automation-id="condition-actions-button"]'); From a340e173d7b9976b15819a44b913884a63ef0695 Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 10:13:03 +0200 Subject: [PATCH 2/6] [ACS-8886] enable excluded test --- .../authentication/exclude.tests.json | 5 ++++- .../copy-move-actions/exclude.tests.json | 14 +------------- .../delete-actions/exclude.tests.json | 19 +------------------ .../edit-actions/exclude.tests.json | 4 +--- e2e/playwright/list-views/exclude.tests.json | 7 ++++++- e2e/playwright/navigation/exclude.tests.json | 4 +--- e2e/playwright/search/exclude.tests.json | 11 +++++------ .../exclude.tests.json | 4 +--- 8 files changed, 20 insertions(+), 48 deletions(-) diff --git a/e2e/playwright/authentication/exclude.tests.json b/e2e/playwright/authentication/exclude.tests.json index 0967ef424b..cf08a95374 100644 --- a/e2e/playwright/authentication/exclude.tests.json +++ b/e2e/playwright/authentication/exclude.tests.json @@ -1 +1,4 @@ -{} +{ + "C213097" : "https://alfresco.atlassian.net/browse/ACS-5479", + "C286473" : "https://alfresco.atlassian.net/browse/ACS-5996" +} diff --git a/e2e/playwright/copy-move-actions/exclude.tests.json b/e2e/playwright/copy-move-actions/exclude.tests.json index db5930c4b5..0967ef424b 100644 --- a/e2e/playwright/copy-move-actions/exclude.tests.json +++ b/e2e/playwright/copy-move-actions/exclude.tests.json @@ -1,13 +1 @@ -{ - "C217135": "https://hyland.atlassian.net/browse/ACS-8812", - "C291888": "https://hyland.atlassian.net/browse/ACS-8812", - "C291889": "https://hyland.atlassian.net/browse/ACS-8812", - "C217137": "https://hyland.atlassian.net/browse/ACS-8812", - "C217138": "https://hyland.atlassian.net/browse/ACS-8812", - "C217139": "https://hyland.atlassian.net/browse/ACS-8812", - "C217140": "https://hyland.atlassian.net/browse/ACS-8812", - "C217171": "https://hyland.atlassian.net/browse/ACS-8812", - "C217172": "https://hyland.atlassian.net/browse/ACS-8812", - "C217173": "https://hyland.atlassian.net/browse/ACS-8812", - "C217174": "https://hyland.atlassian.net/browse/ACS-8812" -} +{} diff --git a/e2e/playwright/delete-actions/exclude.tests.json b/e2e/playwright/delete-actions/exclude.tests.json index 00ab00aba5..0967ef424b 100644 --- a/e2e/playwright/delete-actions/exclude.tests.json +++ b/e2e/playwright/delete-actions/exclude.tests.json @@ -1,18 +1 @@ -{ - "C217125": "https://hyland.atlassian.net/browse/ACS-8812", - "C217129": "https://hyland.atlassian.net/browse/ACS-8812", - "C217091": "https://hyland.atlassian.net/browse/ACS-8812", - "C280416": "https://hyland.atlassian.net/browse/ACS-8812", - "C290103": "https://hyland.atlassian.net/browse/ACS-8812", - "C280417": "https://hyland.atlassian.net/browse/ACS-8812", - "C217177": "https://hyland.atlassian.net/browse/ACS-8812", - "C280438": "https://hyland.atlassian.net/browse/ACS-8812", - "C290104": "https://hyland.atlassian.net/browse/ACS-8812", - "C217182": "https://hyland.atlassian.net/browse/ACS-8812", - "C217178": "https://hyland.atlassian.net/browse/ACS-8812", - "C217179": "https://hyland.atlassian.net/browse/ACS-8812", - "C217183": "https://hyland.atlassian.net/browse/ACS-8812", - "C280502": "https://hyland.atlassian.net/browse/ACS-8812", - "C217130": "https://hyland.atlassian.net/browse/ACS-8812", - "C217184": "https://hyland.atlassian.net/browse/ACS-8812" -} +{} diff --git a/e2e/playwright/edit-actions/exclude.tests.json b/e2e/playwright/edit-actions/exclude.tests.json index aa475482b0..0967ef424b 100644 --- a/e2e/playwright/edit-actions/exclude.tests.json +++ b/e2e/playwright/edit-actions/exclude.tests.json @@ -1,3 +1 @@ -{ - "XAT-5095": "https://hyland.atlassian.net/browse/ACS-8812" -} +{} diff --git a/e2e/playwright/list-views/exclude.tests.json b/e2e/playwright/list-views/exclude.tests.json index 0967ef424b..5e38362c2a 100644 --- a/e2e/playwright/list-views/exclude.tests.json +++ b/e2e/playwright/list-views/exclude.tests.json @@ -1 +1,6 @@ -{} +{ + "C213217": "https://alfresco.atlassian.net/browse/ACS-6710", + "C261153": "https://alfresco.atlassian.net/browse/AAE-7517", + "C589205": "https://alfresco.atlassian.net/browse/ACS-6710", + "C261150": "https://alfresco.atlassian.net/browse/ACS-6710" +} diff --git a/e2e/playwright/navigation/exclude.tests.json b/e2e/playwright/navigation/exclude.tests.json index 0ebca7ffa4..0967ef424b 100644 --- a/e2e/playwright/navigation/exclude.tests.json +++ b/e2e/playwright/navigation/exclude.tests.json @@ -1,3 +1 @@ -{ - "C280034": "https://hyland.atlassian.net/browse/ACS-8812" -} +{} diff --git a/e2e/playwright/search/exclude.tests.json b/e2e/playwright/search/exclude.tests.json index 1f79b2c29e..931f8c3508 100644 --- a/e2e/playwright/search/exclude.tests.json +++ b/e2e/playwright/search/exclude.tests.json @@ -1,7 +1,6 @@ { - "C290019": "https://hyland.atlassian.net/browse/ACS-6928", - "C290018": "https://hyland.atlassian.net/browse/ACS-6928", - "C699046-3": "https://hyland.atlassian.net/browse/ACS-7464", - "C699498": "https://hyland.atlassian.net/browse/ACS-7682", - "C280034": "https://hyland.atlassian.net/browse/ACS-8812" -} \ No newline at end of file + "C290019": "https://hyland.atlassian.net/browse/ACS-6928", + "C290018": "https://hyland.atlassian.net/browse/ACS-6928", + "C699046-3": "https://hyland.atlassian.net/browse/ACS-7464", + "C699498": "https://hyland.atlassian.net/browse/ACS-7682" +} diff --git a/e2e/playwright/upload-download-actions/exclude.tests.json b/e2e/playwright/upload-download-actions/exclude.tests.json index 1a984fdf0d..0967ef424b 100644 --- a/e2e/playwright/upload-download-actions/exclude.tests.json +++ b/e2e/playwright/upload-download-actions/exclude.tests.json @@ -1,3 +1 @@ -{ - "C297548": "https://hyland.atlassian.net/browse/ACS-8812" -} +{} From a1b9f7df33d82c2182d57ba5f2b041434511b19a Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 11:50:28 +0200 Subject: [PATCH 3/6] [ACS-8886] test fix and added ticket to resovle --- e2e/playwright/delete-actions/exclude.tests.json | 4 +++- .../src/page-objects/components/sidenav.component.ts | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/e2e/playwright/delete-actions/exclude.tests.json b/e2e/playwright/delete-actions/exclude.tests.json index 0967ef424b..c2ad5b849d 100644 --- a/e2e/playwright/delete-actions/exclude.tests.json +++ b/e2e/playwright/delete-actions/exclude.tests.json @@ -1 +1,3 @@ -{} +{ + "C280502": "https://hyland.atlassian.net/browse/ACS-8888" +} diff --git a/projects/aca-playwright-shared/src/page-objects/components/sidenav.component.ts b/projects/aca-playwright-shared/src/page-objects/components/sidenav.component.ts index b7f39e2cc7..07909d9ffe 100644 --- a/projects/aca-playwright-shared/src/page-objects/components/sidenav.component.ts +++ b/projects/aca-playwright-shared/src/page-objects/components/sidenav.component.ts @@ -22,7 +22,7 @@ * from Hyland Software. If not, see . */ -import { SIDEBAR_LABELS } from '../../utils'; +import { SIDEBAR_LABELS, timeouts } from '../../utils'; import { BaseComponent } from './base.component'; import { Locator, Page } from '@playwright/test'; @@ -75,6 +75,7 @@ export class SidenavComponent extends BaseComponent { } async isSidenavExpanded(): Promise { + await this.page.waitForTimeout(timeouts.tiny); return this.expandedSidenav.isVisible(); } From c4d5f2b3d8794bb522da5ca47c27d894502ae48f Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 14:00:30 +0200 Subject: [PATCH 4/6] [ACS-8886] test reexcluded as valid fail --- e2e/playwright/folder-rules/exclude.tests.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/e2e/playwright/folder-rules/exclude.tests.json b/e2e/playwright/folder-rules/exclude.tests.json index 0967ef424b..f8b191b0a7 100644 --- a/e2e/playwright/folder-rules/exclude.tests.json +++ b/e2e/playwright/folder-rules/exclude.tests.json @@ -1 +1,3 @@ -{} +{ + "XAT-897": "https://hyland.atlassian.net/browse/ACS-5503" +} From 01ce4a27b5283174fa024c4ab6f768fc02d22e99 Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 14:38:12 +0200 Subject: [PATCH 5/6] [ACS-8886] test enalbe --- e2e/playwright/list-views/exclude.tests.json | 5 +---- .../components/dataTable/data-table.component.ts | 1 + 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/e2e/playwright/list-views/exclude.tests.json b/e2e/playwright/list-views/exclude.tests.json index 5e38362c2a..337469aaa3 100644 --- a/e2e/playwright/list-views/exclude.tests.json +++ b/e2e/playwright/list-views/exclude.tests.json @@ -1,6 +1,3 @@ { - "C213217": "https://alfresco.atlassian.net/browse/ACS-6710", - "C261153": "https://alfresco.atlassian.net/browse/AAE-7517", - "C589205": "https://alfresco.atlassian.net/browse/ACS-6710", - "C261150": "https://alfresco.atlassian.net/browse/ACS-6710" + "C261153": "https://alfresco.atlassian.net/browse/AAE-7517" } diff --git a/projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts b/projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts index 05aa1d7b32..30fc3bfdd5 100644 --- a/projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts +++ b/projects/aca-playwright-shared/src/page-objects/components/dataTable/data-table.component.ts @@ -157,6 +157,7 @@ export class DataTableComponent extends BaseComponent { const sortColumn = await this.getSortedColumnHeaderText(); let sortOrder = await this.getSortingOrder(); if (sortColumn !== label) { + await this.getColumnHeaderByName(label).hover(); await this.getColumnHeaderByName(label).click({ force: true }); sortOrder = await this.getSortingOrder(); } From 828f33754eb62bb2bbf55c5db4539e3df986d124 Mon Sep 17 00:00:00 2001 From: "akash.rathod@hyland.com" Date: Tue, 8 Oct 2024 16:16:22 +0200 Subject: [PATCH 6/6] [ACS-8886] test fix for admin --- e2e/playwright/list-views/src/tests/trash-admin.e2e.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts b/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts index b781f16ab9..c1a0c3ba47 100755 --- a/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts +++ b/e2e/playwright/list-views/src/tests/trash-admin.e2e.ts @@ -23,9 +23,8 @@ */ import { expect } from '@playwright/test'; -import { ApiClientFactory, NodesApi, Utils, getUserState, test, users } from '@alfresco/aca-playwright-shared'; +import { ApiClientFactory, NodesApi, Utils, test, users } from '@alfresco/aca-playwright-shared'; -test.use({ storageState: getUserState('admin') }); test.describe('Trash admin', () => { const folderAdmin = `C213217-deleteFolder-${Utils.random()}`; let folderAdminId: string;