From 29b9432fee13b66e772ebc019928675d9e2c5f54 Mon Sep 17 00:00:00 2001 From: Katarzyna Kita Date: Fri, 16 Feb 2024 09:30:58 +0100 Subject: [PATCH 1/3] Reverted excluded tests --- e2e/playwright/info-drawer/exclude.tests.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/e2e/playwright/info-drawer/exclude.tests.json b/e2e/playwright/info-drawer/exclude.tests.json index 0df6d0b610..0967ef424b 100644 --- a/e2e/playwright/info-drawer/exclude.tests.json +++ b/e2e/playwright/info-drawer/exclude.tests.json @@ -1,4 +1 @@ -{ - "C299195" : "https://alfresco.atlassian.net/browse/ACS-6688", - "C299189" : "https://alfresco.atlassian.net/browse/ACS-6688" -} +{} From cc6793a72c1a468818d25d260650d3dde0b4dc6d Mon Sep 17 00:00:00 2001 From: Katarzyna Kita Date: Fri, 16 Feb 2024 19:39:46 +0100 Subject: [PATCH 2/3] Removed tests from excluded, small fixes --- e2e/playwright/library-actions/exclude.tests.json | 4 +--- .../library-actions/src/tests/library-actions.spec.ts | 2 ++ .../src/page-objects/components/adf-info-drawer.component.ts | 5 ++--- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/e2e/playwright/library-actions/exclude.tests.json b/e2e/playwright/library-actions/exclude.tests.json index 179a1585f0..9e26dfeeb6 100644 --- a/e2e/playwright/library-actions/exclude.tests.json +++ b/e2e/playwright/library-actions/exclude.tests.json @@ -1,3 +1 @@ -{ - "C286326": "https://alfresco.atlassian.net/browse/ACS-6688" -} \ No newline at end of file +{} \ No newline at end of file diff --git a/e2e/playwright/library-actions/src/tests/library-actions.spec.ts b/e2e/playwright/library-actions/src/tests/library-actions.spec.ts index cc86c77331..3d58b32c49 100644 --- a/e2e/playwright/library-actions/src/tests/library-actions.spec.ts +++ b/e2e/playwright/library-actions/src/tests/library-actions.spec.ts @@ -224,6 +224,7 @@ test.describe('Library actions ', () => { await myLibrariesPage.reload({ waitUntil: domContentLoadedString }); await expect(libraryTable.getRowByName(user2Library2)).toBeVisible(); await libraryTable.getRowByName(user2Library2).click(); + await myLibrariesPage.page.waitForTimeout(1000); await myLibrariesHeader.clickMoreActions(); expect(await libraryMenu.isMenuItemVisible(removeFavoriteButton)).toBe(true); await libraryMenu.clickMenuItem(removeFavoriteButton); @@ -416,6 +417,7 @@ test.describe('Library actions ', () => { await expect(libraryTable.getRowByName(user2Library4)).toBeVisible(); await searchPage.reload({ waitUntil: domContentLoadedString }); await libraryTable.getRowByName(user2Library4).click(); + await searchPage.page.waitForTimeout(1000); await searchHeader.clickMoreActions(); await libraryMenu.clickMenuItem(removeFavoriteButton); await searchHeader.clickMoreActions(); diff --git a/projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts b/projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts index f52ffa1ce0..935b213ac2 100644 --- a/projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts +++ b/projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts @@ -40,7 +40,7 @@ export class AdfInfoDrawerComponent extends BaseComponent { public propertiesTab = this.page.getByRole('tab', { name: 'Properties' }); public commentsTab = this.page.getByRole('tab', { name: 'Comments' }); public infoDrawerTabs = this.getChild('.adf-info-drawer-tab'); - public commentInputField = this.getChild('mat-form-field'); + public commentInputField = this.page.locator('#comment-input'); public commentsHeader = this.getChild('#comment-header'); public addCommentButton = this.getChild('[data-automation-id="comments-input-add"]'); public commentsList = this.getChild('.adf-comment-list-item'); @@ -79,8 +79,7 @@ export class AdfInfoDrawerComponent extends BaseComponent { } async addCommentToNode(commentText: string): Promise { - await this.commentInputField.click(); - await this.page.keyboard.type(commentText); + await this.commentInputField.fill(commentText); await this.addCommentButton.click(); } From cb6890116b66a838ad937bdde9a226533daf9b9a Mon Sep 17 00:00:00 2001 From: Katarzyna Kita Date: Fri, 16 Feb 2024 19:44:44 +0100 Subject: [PATCH 3/3] Added missing new line --- e2e/playwright/library-actions/exclude.tests.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/playwright/library-actions/exclude.tests.json b/e2e/playwright/library-actions/exclude.tests.json index 9e26dfeeb6..0967ef424b 100644 --- a/e2e/playwright/library-actions/exclude.tests.json +++ b/e2e/playwright/library-actions/exclude.tests.json @@ -1 +1 @@ -{} \ No newline at end of file +{}