Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search on mobile opens Sidemenu #927

Closed
MariusGrunenberg opened this issue Feb 11, 2019 · 2 comments
Closed

Search on mobile opens Sidemenu #927

MariusGrunenberg opened this issue Feb 11, 2019 · 2 comments
Labels
Milestone

Comments

@MariusGrunenberg
Copy link
Contributor

Describe the bug
When I use the Content App on a mobile device and search for something the sidemenu opens.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to the application
  2. Enter a search term
  3. Hit enter
  4. Now the side menu is open

Expected behavior
Expected behavior would be to see the search results.

Screenshots
https://drive.google.com/open?id=1Z0XoFvnu9P1FF2DvmMFCEeBnN7fuwVuf

Smartphone (please complete the following information):

  • Device: [e.g. iPhone 5]
  • OS: iOS 8
  • Chrome
@DenysVuika DenysVuika added the bug label Feb 11, 2019
@MariusGrunenberg
Copy link
Contributor Author

Think I can provide a fix for this one. Will create a pull request

@MariusGrunenberg
Copy link
Contributor Author

I have created a pull request which seems to fix it for now. What I don't quite understand yet is the check in this line: https://github.com/Alfresco/alfresco-ng2-components/blob/cc396e2a113b7972873624b11b2191c4c6dd3851/lib/core/layout/components/layout-container/layout-container.component.ts#L82

So basically what happens, currently ACA checks if the new route is a search route and the toggles the menu. Which is confusing, since it should only minimize it.

@john-knowles john-knowles added this to the 1.7.0 milestone Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants