Slashes not escaped when searching

[MariusGrunenberg]

Type of issue: (check with "[x]")

• New feature request
• Bug
• Support request
• Documentation

Current behaviour:
I have a folde with following name: "myFolder 1/18" containing a slash "/".

When I search for it, the quick search shows the correct results. Once I hit enter and go to the search page I will receive an error, since the slashes are not escaped and the Angular Routing understands them as part of the URL.

When I search for it using the alfresco

Expected behavior:
I should be able to search with a string containing a slash.

Component name and version:
It's inside the search.effect.ts :

alfresco-content-app/src/app/store/effects/search.effects.ts

Line 40 in dc9a314

this.router.navigateByUrl('/search;q=' + action.payload);

[john-knowles]

Thank you for raising this issue; we've logged it into our JIRA project and will investigate in due course.
https://issues.alfresco.com/jira/browse/ACA-2038

[MariusGrunenberg]

I can provide a possible fix, will create a pull request later today.

[M3noetius]

I can provide a possible fix, will create a pull request later today.

Have you come up with solution? We would really like to have a chance to fix and contribute with a friend. Thanks

[john-knowles]

We have not started working on it yet, your contribution will be greatly appreciated! Please create a pull request to "development" branch, thank you 👍

[M3noetius]

Our biggest question is how did you manage to create this folder. We are trying to create this folder both from the os (windows and linux) and the platform (we initially thought that here was the problem). The os does not let this type of folder creation as expected due to the system file access architecture The web app on the other hand correctly implements input validation and prompts the user for an error. As you can see from the proxy (picture) the "bad input" message comes correctly from the server side of the app, which means there is no client error, due to the absence of an unloaded ex. javascript input checking file/function.

We can not reproduce the issue. Can you provide us with more information ? Are you using any unicode trick? I can see that you created the issue before 11 days so I assume that you use the latest version of the app. @MariusGrunenberg

Thank you!

[DenysVuika]

@M3noetius I think the issue is not in the search calls, but redirecting to the search results page. I guess the encode/decode URI fragment is needed for the query portion not to break the routing itself, see the link in the original issue:

alfresco-content-app/src/app/store/effects/search.effects.ts

Line 40 in dc9a314

this.router.navigateByUrl('/search;q=' + action.payload);

I believe with 'myFolder 1/18' the url becomes /search;q=myFolder 1/18 and /18 is treated as a child route path.

[M3noetius]

@DenysVuika I see what you mena.I was so fascinated about folders with forward slash ("I have a folde with following name") that I did not focus at the rest of the issue.
So some encoding will most probably do the trick. We will try to fix it !

[MariusGrunenberg]

@M3noetius I have created a PR, where I fixed the Encoding. So feel free to use my fix.

It has worked for me in a project