added the fav icon #41 #68
Conversation
✅ Deploy Preview for delightful-daifuku-a9f6ea ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🎉 Thank you @Kratik1093 for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.
|
@Kratik1093 If it's visible at your side can you share the image. |
|
|
frontend/package.json
Outdated
| "main": "postcss.config.js", | ||
| "author": "", | ||
| "license": "ISC", | ||
| "description": "" |
There was a problem hiding this comment.
@Kratik1093 why did you added these lines here?
There was a problem hiding this comment.
to make this page run on my device i need to made these change otherwise the page was not starting on my device
There was a problem hiding this comment.
@Kratik1093 then please remove this while pushing the PR and use it for local only
There was a problem hiding this comment.
ok will keep note of it for next time
There was a problem hiding this comment.
@Kratik1093 the above lines need to be removed to merge this Pr. Please remove it asap.
|
Please reply to the comment and I am still not able to see the icon. |
|
@AlfiyaSiddique I am also could understand why this is not working when deployed i checked the deployed code also but iant able to understand the problem is the image in public section named tastytrial512.png , changes in html are visible to you in the deploy?? |
|
@Kratik1093 please update the pr and add the chnages I have commented |
|
@Kratik1093 any updates? |
|
@Kratik1093 will be closing this PR and issue if no activity found by tomorrow. |
👷 Deploy request for delightful-daifuku-a9f6ea pending review.Visit the deploys page to approve it
|
added the new fav icon which matches theme of the food website
issue no. #41