Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #26 Add Recipe #38

Closed
wants to merge 2 commits into from

Conversation

ZayedShahcode
Copy link

The code seemed perfect. There was one simple mistake in authorization header which I believe is the cause of error.

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for delightful-daifuku-a9f6ea ready!

Name Link
🔨 Latest commit 8f9f3f9
🔍 Latest deploy log https://app.netlify.com/sites/delightful-daifuku-a9f6ea/deploys/66fd859d2cb6e600089710d9
😎 Deploy Preview https://deploy-preview-38--delightful-daifuku-a9f6ea.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @ZayedShahcode for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better.

@AlfiyaSiddique
Copy link
Owner

@ZayedShahcode please tag this PR is related to which issue. Tag the issue number

@ZayedShahcode ZayedShahcode changed the title Fixed Add Recipe #26 Closes #26 Add Recipe Oct 3, 2024
@ZayedShahcode
Copy link
Author

ZayedShahcode commented Oct 3, 2024

issue fix #26

@ZayedShahcode
Copy link
Author

@AlfiyaSiddique I added the issue number in title and comments. Is that right?

@ZayedShahcode ZayedShahcode changed the title Closes #26 Add Recipe fixes #26 Add Recipe Oct 3, 2024
@AlfiyaSiddique
Copy link
Owner

@ZayedShahcode The error still exists:

Screen.Recording.2024-10-03.223312.mp4

Please fix it and test well.

@AlfiyaSiddique
Copy link
Owner

@ZayedShahcode this is an imp issue, It is blocking many other workflows. Please fix it as soon as possible.
If you are occupied please allow me to assign to someone else.

@ZayedShahcode
Copy link
Author

@AlfiyaSiddique I tested in my local server and it works. Only change I did was what i committed i.e 'token' instead of "TOKEN". Could you please check if you provided the correct read and write permissions to your github api token. For testing I provided all the permissions to my api token. Below is the proof.

test.mp4

@AlfiyaSiddique
Copy link
Owner

@ZayedShahcode This does not fix the issue on a production level.
This is due to some configuration issues from the deployment side and has been fixed.
Hence closing this issue and PR.
Thanks for drawing our attention to this issue.
We apologize as we cannot give points on this since no code change is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants