Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great Demo, Thank you #2

Open
waelsaad opened this issue Jul 31, 2018 · 5 comments
Open

Great Demo, Thank you #2

waelsaad opened this issue Jul 31, 2018 · 5 comments

Comments

@waelsaad
Copy link

I've learn't a lot from this, thank you it came to me at the right time, there is still room for improvements. If there was a better way to make callWithToken a bit more generic and avoid the repeated lines of code for each entity that would be awesome but seriously thank you.

@Alexsilvacodes
Copy link
Owner

Yep, it was done a bit on a rush, there's a lot of work in refactoring code, etc, but I'm glad that you find it useful! If you want to make some changes I'm totally open for it :D

@waelsaad
Copy link
Author

waelsaad commented Oct 26, 2018

One more important thought as I am now integrating it in a project I am working on. I believe all these classes should be Decodable and remove Alamofire and EVReflection, the implementation will be cleaner and simpler, I understand there is an effort to do this but it will be better hopefully you will actually consider when you have time. Thanks

@Alexsilvacodes
Copy link
Owner

I was thinking about it the other day. Now I have a bit more time, I will start working on it. Thanks for the suggestion!

@waelsaad
Copy link
Author

Excellent and thank you for the prompt response and considering it, I'll be watching the branch :)

@Alexsilvacodes
Copy link
Owner

I started working right now adapting the API to Codable/Decodable, in fact it should be working more or less fine, I'm just adapting the Sample code and trying to create Unit tests. You can take a look in codable branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants