Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated link to single cell course #519

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Conversation

sjspielman
Copy link
Member

Updated the broken link to address #518.

The updated file is an md, not Rmd, so I'm not sure if it should be re-rendered but assuming not(?). For now did not re-render, but can!

@sjspielman sjspielman requested a review from jashapiro February 23, 2022 20:42
@jashapiro
Copy link
Member

The updated file is an md, not Rmd, so I'm not sure if it should be re-rendered but assuming not(?). For now did not re-render, but can!

The .md files do need to be rendered manually; the list of files that will be automatically rendered is here: https://github.com/AlexsLemonade/training-modules/blob/master/scripts/render-live.sh#L18-L42]

Otherwise, looks good, but I'll wait for the render to approve.

@sjspielman
Copy link
Member Author

the list of files that will be automatically rendered is here: [https://github.com/AlexsLemonade/training-modules/blob/master/scripts/render-live.sh#L18-L42]](https://github.com/AlexsLemonade/training-modules/blob/master/scripts/render-live.sh#L18-L42%5D)

Thanks!

Copy link
Member

@jashapiro jashapiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sjspielman sjspielman merged commit e480ef1 into master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants