-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider updating ggplot2 functions xlab/ylab --> labs() #520
Comments
I don't have a problem with this, but just a caution that it may be a bit bigger than it appears at first. If we replace all of the code we have, we will need to make this change in all training modules (not just intro), and in all exercise notebooks, and make sure we update the cheat sheets. Another option, which I might prefer, is to keep One very nice thing about |
^ This is a huge benefit. I definitely see how it is a bigger task than it appears at first, since labeling figures is of course a common activity in ~every day's notebook. What you propose about adding in
Then, in other notebooks, we add a sentence here and there like "you can also use |
It also seems that |
All of those modules are not going to be relevant for this training, FWIW. |
Given the above, I think it definitely makes sense to introduce |
Tagging @cbethell as our |
Closed with #522. |
Currently, we teach separate
xlab
,ylab
, andggtitle
functions. I very strongly recommend we update materials to use the overall functionlabs()
, which can take args like..I think this is also small enough to pretty easily accomplish before March 2022, if there is interest in this minor update.
The text was updated successfully, but these errors were encountered: