Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cheatsheet links #515

Closed
jashapiro opened this issue Feb 14, 2022 · 12 comments
Closed

Update cheatsheet links #515

jashapiro opened this issue Feb 14, 2022 · 12 comments
Assignees

Comments

@jashapiro
Copy link
Member

The training modules we have in the module-cheatsheets directory often point to documentation on http://rdocumentation.org, which seems to be either decaying or defunct. The most recent versions of packages described there are often out of date, including base R, which is only a max version of 3.6.2.

While this should not affect most of the content we are referring to, there are changes with R 4.0 that may come up, so we may want to update those links.

I also noticed that there were some links that no longer work (if they did before). These include the links to scran and scater, which point to versions past the ones that rdocumentation.org supports.

One idea is to switch over to https://rdrr.io, which seems to have more recent documentation. However, the documentation there is not versioned, so we would just be pointing people to whatever the latest (or at least fairly current) version of a particular function was. This may not be terrible, given that the links won't have to change in the future, but it is a little disappointing that you can't look up previous versions if the need arises.

@sjspielman sjspielman assigned sjspielman and unassigned sjspielman Feb 15, 2022
@jaclyn-taroni
Copy link
Member

This was slotted for this sprint, so wanted to give this a little "bump." It would be good to have this in progress before we meet next Tuesday.

@sjspielman
Copy link
Member

Welp, @jaclyn-taroni this accidentally fell prey to my exploration of "why wont github notify me when I self-assign." Back on it now 💯

@sjspielman
Copy link
Member

I think https://rdrr.io/ makes sense for this. One way to deal with versioning is to have a big caveat at the top of each cheatsheet, inside the existing blockquotes. For example, change:

The hyperlinks found in each piece of code will take you to the documentation for further information on the usage of each command.

to:

The hyperlinks found in each piece of code will take you to the documentation for further information on the usage of each command. Please be aware that the documentation will generally provide information about the given function's most current version, which will usually (but not always!) match what you have installed on your machine.

@sjspielman
Copy link
Member

sjspielman commented Feb 25, 2022

Will our RStudio server setup match the most up-to-date packages? For example, if we are using older versions of tidyverse packages, the documentation is potentially misleading. If our server is on older versions, we'll need something besides rdrr for tidyverse specifically. I don't expect anything in base R/utils to differ between versions 3-4, as long as we aren't doing |>.

Edit: This might be my brain on PBTA-mode with the older rocker.

@jashapiro
Copy link
Member Author

jashapiro commented Feb 25, 2022

We are not using the most up-to-date, because we freeze with renv, but we are on R 4 now, and the versions are pretty new.

Current version info (TMI):
https://github.com/AlexsLemonade/training-modules/blob/master/renv.lock

(Yes, you are thinking of PBTA... we are trying to keep this more current!)

@sjspielman
Copy link
Member

@jashapiro Any strong feelings for/against using tidyverse.org domain links for the tidyverse packages? For those functions, I think it will be more helpful for users because all of tidyverse is integrated there, and it's easier to hop around to vignettes and other functions. I don't see those links changing anytime soon.

@jashapiro
Copy link
Member Author

@jashapiro Any strong feelings for/against using tidyverse.org domain links for the tidyverse packages? For those functions, I think it will be more helpful for users because all of tidyverse is integrated there, and it's easier to hop around to vignettes and other functions. I don't see those links changing anytime soon.

I think those should be fine. I wish they allowed version-specific links, but since we have to abandon that anyway...

@jashapiro
Copy link
Member Author

closed by #521

@jashapiro
Copy link
Member Author

Oops, not closed. The following cheatsheets still need updates to match the changes in #521

@jashapiro jashapiro reopened this Mar 3, 2022
@jaclyn-taroni
Copy link
Member

Should we file a separate issue for the remaining cheatsheets? We don't necessarily need those to be fixed before this training (as they are not immediately relevant). I know we link to them somewhere in the course website, but all links to the course website are "governed" by the release tag and we've already cut the release.

@jashapiro
Copy link
Member Author

Yes, a separate issue would probably be better.

@jaclyn-taroni
Copy link
Member

Filed #528 - closing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants