Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treemacs icons shouldn't change 'modifed flag in regular dired buffers. #1123

Closed
agzam opened this issue Oct 3, 2024 · 0 comments · Fixed by #1124
Closed

treemacs icons shouldn't change 'modifed flag in regular dired buffers. #1123

agzam opened this issue Oct 3, 2024 · 0 comments · Fixed by #1124

Comments

@agzam
Copy link
Contributor

agzam commented Oct 3, 2024

When icons are enabled in Dired - (add-hook 'dired-mode-hook #'treemacs-icons-dired-mode), the buffer becomes "unsaved" - attempts to kill a Dired buffer cause a popup to appear, asking if you want to save it. It looks like the treemacs-icons-dired--display hooked onto 'dired-after-readin-hook cause that and it shouldn't. Specifically it calls treemacs-icons-dired--display-icons-for-subdir which at some point does (insert icon), and that causes the buffer to become "modified".
Dired buffers shouldn't be "modified".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant