Always remove extract-css-loader on server #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... even when `cricitcalCSS` is disabled. This fixes the `document is not defined` bug in production mode Fixes Akryum#186
|
Interested to have this merged 👍 |
This was referenced Jun 28, 2020
sneko
added a commit
to sneko/vue-cli-plugin-ssr
that referenced
this pull request
Jul 8, 2020
|
Just decided to use my own fork with I did it be aliasing this repo: I really hope in the future all critical PR will be merged, it's a great SSR plugin but it comes with too many breaks 😢 |
sneko
added a commit
to sneko/vue-cli-plugin-ssr
that referenced
this pull request
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... even when
cricitcalCSSis disabled. This fixes thedocument is not definedbug in production modeFixes #186