Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller: don't request new backup if we're already at the maximum #141

Conversation

aiven-amartin
Copy link
Contributor

About this change: What it does, why it matters

Currently if we get a bunch of backups for whatever reason, this wave pattern is amplified by the way we request backups.

This PR attempts to fix that by not requesting a scheduled backup if we're already over the maximum count, which should short-circuit this wave.

@aiven-amartin aiven-amartin linked an issue Feb 9, 2023 that may be closed by this pull request
@aiven-amartin aiven-amartin force-pushed the aiven-amartin/avoid-requesting-backups-when-over-max branch from c3825ee to 43f0136 Compare February 9, 2023 17:50
@jelmer
Copy link
Contributor

jelmer commented Feb 10, 2023

Am I understanding correctly that this would only prevent scheduling new backups from myhoard's internal scheduling loop, not external requests? That seems like a feature, but perhaps good to emphasize here.

What happens if the existing backups get stuck for some reason? Does that mean we just never schedule anything new - presumably we'd still get a backupage alert in that case?

@rikonen
Copy link
Contributor

rikonen commented Feb 13, 2023

I would perhaps wait and see how the cloud provider fixes progress since at the moment it looks like we cannot rely on the object storage API and it may not be meaningful to try to work around the most critical component the software deals with being broken.

@aiven-amartin
Copy link
Contributor Author

Closing for now in favour of investigation into how to handle unstable object storage APIs as the real root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Myhoard allows too many streams
3 participants