You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Protobuf and JSONSchema implementations currently have dependencies on Avro's SchemaCompatibilityResult. These implementations should be independent from each other. If we need a container to carry compatibility check results, we should define our own and not piggy-back on Avro's implementation.
Other than best-practice, this also has implications on type-checking, since we pass in objects of the wrong type to the fields of Avro-specific entities. In this example, we pass in list[str] for incompatibilities, where a avro.compatibility.SchemaIncompatibilityType is expected.
The Protobuf and JSONSchema implementations currently have dependencies on Avro's
SchemaCompatibilityResult
. These implementations should be independent from each other. If we need a container to carry compatibility check results, we should define our own and not piggy-back on Avro's implementation.Other than best-practice, this also has implications on type-checking, since we pass in objects of the wrong type to the fields of Avro-specific entities. In this example, we pass in
list[str]
forincompatibilities
, where aavro.compatibility.SchemaIncompatibilityType
is expected.The text was updated successfully, but these errors were encountered: