Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No stack trace for AirtableError #294

Open
vubogovich opened this issue Jan 27, 2022 · 4 comments · May be fixed by #402
Open

No stack trace for AirtableError #294

vubogovich opened this issue Jan 27, 2022 · 4 comments · May be fixed by #402

Comments

@vubogovich
Copy link

Is there any reason AirtableError is not extending Error and therefore missing the stack trace so useful to debug errors?

vubogovich pushed a commit to Qualifyze/airtable that referenced this issue Jan 27, 2022
Official client error class does not extend `Error` so no stack trace :(
See Airtable/airtable.js#294
vubogovich pushed a commit to Qualifyze/airtable that referenced this issue Jan 27, 2022
Official client error class does not extend `Error` so no stack trace :(
See Airtable/airtable.js#294
@albreyb
Copy link
Contributor

albreyb commented Feb 17, 2022

Thank you for calling this out. It's a good suggestion for us to extend AirtableError from Error. We will look into this and see if we can introduce this without breaking backwards compatibility.

@aburgel
Copy link

aburgel commented Mar 7, 2023

This would be a very nice addition. It's a bit difficult to debug failures at the moment since you have add your own logging to identify where errors are occurring.

@edelbalso
Copy link

Hi folks, our team lost some time in our new project since we we couldn't figure out where this error was coming from without a stack trace. Just want to add a vote to the suggestion of extending the Error object in this and how simple/valuable that would be to get our exception handler (sentry in this case) to actually surface the stacktrace.

@domdomegg domdomegg linked a pull request Apr 5, 2024 that will close this issue
@domdomegg
Copy link

domdomegg commented Apr 5, 2024

I've raised a PR that fixes this: #402.

This makes errors significantly easier to debug and trace down! Although note that this doesn't make the errors perfect - by the way the SDK is constructed errors that are raised in asynchronous contexts still sometimes don't have the most useful stacktraces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants