-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty query params #238
Comments
For some fields empty string may have another meaning: no entries to return. For example, I generate some Patient ID set and want to get these entries so I just do |
@ruscoder fixed. please check it and give us feedback. |
Thanks! I'll test it |
Keep us updated. |
Works great! |
Hi!
GET /Patient?_id=
will create request such asparams: {_id: ''}
and to handle it correctly we need to check that value != null and value != ''.Security note
For Aidbox's users it leads to security issues when developers forgot to check minLength in policies, e.g.
and for
GET /Patient?_id=
this policy will allow the query, and the user will have an access to ALL patients in the system.As workaround we use a bit enhanced policy, but it annoying to check
minLength
for required properties.The text was updated successfully, but these errors were encountered: