Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all of the uses of std::pair<int, int> to be sf:vector2<int> #74

Closed
gyurgyma opened this issue May 11, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@gyurgyma
Copy link
Collaborator

To standardize with vector3 we should use vector2. The main change here is to turn all of the IntPairs in PathFinder::pathFind to vector2.

Also, maybe look into using float as our returned distance values for pathFind. This may help significantly for accuracy. This will decrease performance slightly, so make sure that it's fully tested and does in fact increase accuracy by a noticeable margin.

@gyurgyma gyurgyma added this to the GB 0.0.3 milestone May 11, 2017
@gyurgyma gyurgyma self-assigned this May 11, 2017
@gyurgyma
Copy link
Collaborator Author

nlohmann/json#486

@gyurgyma
Copy link
Collaborator Author

gyurgyma commented May 12, 2017

Tabling for now. Can't handle this VS compiler bug.

@gyurgyma gyurgyma removed this from the GB 0.0.3 milestone May 13, 2017
@gyurgyma gyurgyma added this to the GB 0.0.4 milestone Jun 23, 2017
@gyurgyma
Copy link
Collaborator Author

Updated this to: Change all instances of IntPair and pair<T,T> to be Point2D/3D

@lavinrp lavinrp closed this as completed Jun 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants