Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Background Voting Loop #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove Background Voting Loop #38

wants to merge 2 commits into from

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Sep 13, 2024 •
edited
Loading

Duplicating similar work in other dapps
See PR in offer-up and PR in dapp-agoric-basics

also removing version from docker compose file.

This is another case of...

@amessbee amessbee self-assigned this Sep 13, 2024
@amessbee amessbee requested review from Jovonni and dckc September 13, 2024 04:41
@amessbee
Copy link
Contributor Author

@Jovonni mentioned that since orca-dapp currently does not use run-chain.sh in its pipeline, it won't be much help updating it. However, he also points out that we may use it in future to keep a consistent view of dapp development. Therefore, I see no harm in merging this benign thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dckc dckc dckc approved these changes

@Jovonni Jovonni Awaiting requested review from Jovonni

Assignees

@amessbee amessbee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amessbee @dckc