Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Allow UI to build against latest agoric-sdk #39

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Feb 1, 2022

Take on explicit @endo/marshal and @endo/captp dependencies to satisfy parcel-bundler. Preliminary CI fix for Agoric/agoric-sdk#4433.

Also minimally reorganizes some dependencies between dev and prod. This does not switch the @agoric deps away from *, leaving in place older dependencies in yarn.lock, since the current usage is through a linked agoric cli.

@mhofman
Copy link
Member Author

mhofman commented Feb 1, 2022

This does not switch the @agoric deps away from *, leaving in place older dependencies in yarn.lock

cc @kriskowal, I'll let you handle the agoric install dev ceremony, since you'll have to manually update some package.json for the packages moving to endo.

Take on explicit @endo/marshal and @endo/captp dependency to satisfy parcel
Reorganize some dependencies between dev and prod
@samsiegart
Copy link
Contributor

Also minimally reorganizes some dependencies between dev and prod

I don't want to complicate things as long as this is working, but does it break if we keep those as devDependencies? In the wallet UI, for example, everything is a devDependency because there's no production service running, just the dev server and build script.

@mhofman
Copy link
Member Author

mhofman commented Feb 1, 2022

In the wallet UI, for example, everything is a devDependency because there's no production service running, just the dev server and build script.

There are changes in 2 directions:
parcel bundler is clearly a dev dependency, so moved that there.

Then I usually consider anything that gets bundled into the runtime as a prod dependency, not a dev dependency for static apps, which I believe dapps are. I'm happy to revert this if that's not how we structured the ui of our dapps.

@samsiegart
Copy link
Contributor

Then I usually consider anything that gets bundled into the runtime as a prod dependency, not a dev dependency for static apps, which I believe dapps are. I'm happy to revert this if that's not how we structured the ui of our dapps.

SGTM, as @michaelfig mentioned, trimming down the runtime deps is only significant in the SDK, and we can use this more regular approach in the static dapps

@mhofman mhofman merged commit 4da43bf into main Feb 1, 2022
@mhofman mhofman deleted the mhofman/fix-ui-build branch February 1, 2022 22:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants