Voters can't tell how they voted

[Chris-Hibbert]

Describe the bug

The voting UI doesn't tell voters that they voted, and doesn't give them a way to find out what issues they've voted on.

To Reproduce

Steps to reproduce the behavior:

1. Set up with an ID as one of the committee members
2. visit https://econ-gov.inter.trade/?agoricNet=ollinet
3. wait till there's a vote scheduled. Vote.
4. Click on the button at the bottom to "Submit vote".
5. Approve the vote in the Keplr UI

Expected behavior

The UI should show that the vote is being submitted, and when the chain accepts it, it should tell the user that their vote was sent.

There should also be a way to find out which questions have been voted on. The Vote tab shows all open questions, whether the use has voted already or not. The history tab shows all questions, with no indication of which ones the user voted on, or what position was supported.

Additional context

The first issue could be completely handled in the UI. The second requires support in the back end. The ballotCounter does not reveal who or how many votes have been cast. The individual voter facet could track whether the voter has voted on each particular issue, though it's not obvious who that should be accessible to.

When rallying votes it's helpful to be able to see how many votes have been cast. We don't currently make that available.

[Tartuffo]

@rowgraus is the second part ("The history tab shows all questions, with no indication of which ones the user voted on, or what position was supported.") a launch blocker, or can we assume the econ committee members are savvy enough to have remembered / written this down this info? Fixing it requires a change to the contract.

[dckc]

possible approach: scribble something in localhost about which way you voted

or at least show that the offer went through

and there's as to whether the running tally should be visible from the contract level... we run in a public blockchain, after all

[dckc]

@otoole-brendan @rowgraus another work-around / mitigation: their votes do show up as WalletSpendAction transactions in block explorers along with their trades; for example, votes of "gov2" on agoricollinet-44 show up at https://ollinet.explorer.agoric.net/agoric/account/agoric1ldmtatp24qlllgxmrsjzcpe20fvlkp448zcuce .

We could easily turn the address display at the top of dapp-econ-gov into a link to that URL.

Figuring out how they voted is a little tricky, but for parameter changes, it's a matter of finding changes or noChanges in their spendAction. This one shows changes so it's a yes vote, and board00530 identifies which question this vote is responding to:

And perhaps we could persuade / incentivize explorer devs to display those in a more readable fashion.

[turadg]

@dckc notes this may be possible without ballotCounter changes. For parameter changes, it's a matter of finding changes or noChanges in their spendAction. The board ID identifies which question this vote is responding to.

[otoole-brendan]

I'm thinking it's quite valuable to expand scope of this ticket to include providing overall status of the proposal vote by giving cumulative view across all voters, not just the user in question i.e. so any EC user can see overall vote status in history tab i.e. Proposal Board XXXX Yes = 3 No = 2