Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and Update Testing Workflow After EC Changes Are Integrated into Mainnet #138

Open
rabi-siddique opened this issue Oct 7, 2024 · 0 comments
Assignees

Comments

@rabi-siddique
Copy link
Contributor

rabi-siddique commented Oct 7, 2024

Current Status of EC Changes in A3P and End-to-End Testing

As of now, the EC changes have not yet been integrated into the Agoric mainnet or into the A3P images. Therefore, for the time being, when conducting end-to-end (E2E) testing, spin up an A3P chain in the CI environment and manually apply the new EC changes to the A3P chain by installing the necessary bundles and performing all the important steps using a bash script. This approach ensures that the EC modifications are properly reflected in the A3P chain for testing purposes.

As a result, we now have a new committee and charter in place. This means that we can execute E2E tests, covering the intended functionality including the changes made to the committee and the charter.

Important Next Steps Once EC Changes are Part of the Mainnet

Once the EC changes are fully integrated into the mainnet (you can track the status here: Agoric Projects), it will no longer be necessary to apply these changes during testing manually. At that point, cleanup tasks must be completed to ensure the system is aligned with the latest mainnet changes:

  1. Remove obsolete testing scripts and files:

    • tests/e2e/scripts/b1-2197fbaf5b94e79dd80546b3ce6aab47e52679667668ad1af614869aeb0bbadc529b34acfc01c37ae6cc5cd328d6aaf59f7818bcf15dc315405f7bda3a4d3472.json
    • tests/e2e/scripts/b1-f9881996d17ce444c7fa34f3a8ea20ecbec403344b83a805b91f35f06bb65bd7c09519d9bc1560d5e55aed0fca547a5f3851234c45720b85c11c9143a48364e7.json
    • tests/e2e/scripts/replace-committee-A3P_INTEGRATION-permit.json
    • tests/e2e/scripts/replace-committee-A3P_INTEGRATION.js
    • tests/e2e/scripts/run-chain.sh
    • tests/e2e/scripts/setup-committee.sh
    • tests/e2e/Dockerfile

    These files are tied to the temporary workaround we used for the EC changes in A3P testing. Once the mainnet is updated, these scripts and files become redundant and should be deleted to avoid confusion or accidental usage.

  2. Update Docker Compose Configuration:

    • Make sure to update the docker-compose-invitation.yml file to reference the latest A3P image that includes the finalized EC changes.
@rabi-siddique rabi-siddique self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant