Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start with any search string such as offer id #11

Open
dckc opened this issue Nov 8, 2024 · 5 comments
Open

start with any search string such as offer id #11

dckc opened this issue Nov 8, 2024 · 5 comments
Assignees

Comments

@dckc
Copy link
Member

dckc commented Nov 8, 2024

As a user, I want to enter a search term and have everything before the 1st occurrence of that term filtered.
(everything except the parts of the slog file that give vat names)

For example, the precipitating event in my Aug 23 case was proposing a DebtLimit change. Like all smart contract interactions, the relevant transaction has an OfferSpec including an id. The user could provide the id, and the service would find where that id shows up and extract from there for the following 10 or 20 seconds.

@rabi-siddique rabi-siddique self-assigned this Nov 21, 2024
@rabi-siddique
Copy link
Collaborator

rabi-siddique commented Nov 21, 2024

This seems very cool. Do you think we should add a Next button on the UI to load logs in 20-second intervals for easier navigation? I think that can help in quickly viewing logs in manageable 20-second chunks.

@dckc
Copy link
Member Author

dckc commented Nov 21, 2024

a Next button does seem like a straightforward enhancement.

I don't recall any specific situations where it would have been useful, but if someone were looking at a phenomenon that takes longer than a few blocks, then yes, it would be handy.

@dckc
Copy link
Member Author

dckc commented Nov 21, 2024

Also: this request for "start by searching for a string" was assuming that the user always uploads a file.

I don't know whether it's feasible when the tool gets logs from emerynet or the like.

@mhofman
Copy link
Member

mhofman commented Nov 21, 2024

With the new contextual slog sender in u18, we may want to enable search by trigger info (e.g. txHash). The event of the same trigger may span across multiple blocks.

@rabi-siddique
Copy link
Collaborator

Also: this request for "start by searching for a string" was assuming that the user always uploads a file. I don't know whether it's feasible when the tool gets logs from emerynet or the like.

It’s feasible. Currently, when fetching testnet logs for a block height query, we search logs within this 90-day range. I believe I can replicate a similar approach for user search terms. The main thing would be to update the Logs Explorer query and determine which time limit (90, 60, or 30 days) offers the best performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants