revert StabilityFee schema change #8084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsiegart
approved these changes
Jul 24, 2023
| | LiquidationPadding | Ratio | | | ||
| | LiquidationMargin | Ratio | Yes | | ||
| | LiquidationPenalty | Ratio | Yes | | ||
| | MintFee | Ratio | Yes | | ||
| | LoanFee | Ratio | Yes | |
There was a problem hiding this comment.
This is still MintFee, same below on line 63
turadg
force-pushed
the
8079-fix-vaults-upgradability
branch
from
9173458 to
c3a6912
Compare
mhofman
pushed a commit
that referenced
this pull request
Aug 7, 2023
revert StabilityFee schema change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8079
Description
#7871 made an innocuous seeming string change. Each commit was called out as a BREAKING CHANGE, but we expected that was only to API consumers. We've since discovered that it broke compatibility with Mainnet ( #8079 ) because we don't yet have a facility for schema migrations. (see #7407 and #7337 )
The simple renaming affected three data tables, one of which has a stateShape schema validation that prevents loading. The other two we could limp along by always reading the two possible names, but we shouldn’t.
This restores a blocker to upgradability by reverting #7871. There may be others to be discovered so it doesn't yet close 8079.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
Testing Considerations
CI
Upgrade Considerations
This restores upgradability.