Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xsnap)!: Update to Moddable SDK 3.8.7 #7498

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Apr 24, 2023

closes: #7083

Refs: agoric-labs/moddable#9, agoric-labs/xsnap-pub#38 (Will be merged first then this PR updated with the resulting commits)

Description

Update to Moddable SDK 3.8.7, the latest published tag

This includes a change to consider WeakRef as strong during organic gc, mitigating #6784.
This includes an upstream change that grows the property map table as needed, affecting some tests.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Updated xsnap tests to handle the property map allocation change (test disabled), and WeakRef change by switching to a FinalizationRegistry observer instead.

Given the change to WeakRef handling I'm now adapting the acceptance test described in #6929 as follow:

@mhofman mhofman requested review from michaelfig and warner and removed request for michaelfig April 24, 2023 20:47
Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll be curious to see the memory-usage consequences of the WeakRef changes. Making GC more stable is a good thing, but this will also prolong the lifetime of basically every virtual-object Representative until the next BOYD, which might increase memory pressure, and may encourage us to reduce the reapInterval so they'll happen faster. OTOH, once there's enough headroom, it probably won't matter much.

@mhofman
Copy link
Member Author

mhofman commented Apr 26, 2023

All replay tests passed! Merging.

@mhofman mhofman added the automerge:rebase Automatically rebase updates, then merge label Apr 26, 2023
mhofman added 3 commits April 26, 2023 21:57
Moddable SDK 3.8.7
xsnap-native:
- handle creation option change
Use FinalizationRegistry alone instead of WeakRef to track gc
Property key no longer result in exhaustion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade XS to 3.8
2 participants