Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make agoric --sdk basically work again #459

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

michaelfig
Copy link
Member

This fixes the bitrot that I introduced in modifying @agoric/eventual-send and @agoric/captp.

Now the template/contract/deploy.js script just needs modification. See the README for instructions on how to set up an agoric --sdk alias.

soil:template michael$ agoric deploy contract/deploy.js 
Chain loaded: chain bundle loaded
running /Users/michael/agoric/agoric-sdk/packages/agoric-cli/template/contract/deploy.js
'fs' is imported by contract/deploy.js, but could not be resolved – treating it as an external dependency
agoric: ERROR: data is not callable, has no method getAssay
soil:template michael$ 

Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll look into the remaining error after lunch

@michaelfig michaelfig removed the request for review from Chris-Hibbert January 27, 2020 20:39
@michaelfig michaelfig merged commit 1dc046a into master Jan 27, 2020
@michaelfig michaelfig deleted the unbitrot-cli branch January 27, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants